Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 26880007: [Android] Consolidate and upgrade OWNERS for test files (Closed)

Created:
7 years, 2 months ago by Miguel Garcia
Modified:
7 years, 2 months ago
CC:
chromium-reviews, tim+watch_chromium.org, craigdh+watch_chromium.org, jam, haitaol+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, rsimha+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Consolidate and upgrade OWNERS for test files Part of a bigger change that can be seen here for context https://codereview.chromium.org/27311005/ BUG=308421 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230400

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
A + chrome/android/host_driven_tests/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/android/javatests/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/android/testshell/javatests/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/android/uiautomator_tests/OWNERS View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/android/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/android/OWNERS View 1 chunk +7 lines, -0 lines 0 comments Download
M sync/test/android/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Miguel Garcia
dtrainor, bulach, yfriedman as owners The rest of you because you will be in a ...
7 years, 2 months ago (2013-10-17 09:56:33 UTC) #1
bulach
I'd propose some small changes here on very specific directories. https://codereview.chromium.org/26880007/diff/1/chrome/android/host_driven_tests/OWNERS File chrome/android/host_driven_tests/OWNERS (right): https://codereview.chromium.org/26880007/diff/1/chrome/android/host_driven_tests/OWNERS#newcode7 ...
7 years, 2 months ago (2013-10-17 12:53:33 UTC) #2
Yaron
lgtm https://codereview.chromium.org/26880007/diff/1/chrome/android/host_driven_tests/OWNERS File chrome/android/host_driven_tests/OWNERS (right): https://codereview.chromium.org/26880007/diff/1/chrome/android/host_driven_tests/OWNERS#newcode7 chrome/android/host_driven_tests/OWNERS:7: skyostil@chromium.org On 2013/10/17 12:53:34, bulach wrote: > are ...
7 years, 2 months ago (2013-10-17 17:07:14 UTC) #3
Miguel Garcia
https://chromiumcodereview.appspot.com/26880007/diff/1/chrome/android/host_driven_tests/OWNERS File chrome/android/host_driven_tests/OWNERS (right): https://chromiumcodereview.appspot.com/26880007/diff/1/chrome/android/host_driven_tests/OWNERS#newcode7 chrome/android/host_driven_tests/OWNERS:7: skyostil@chromium.org Ok, I'll leave this one as is then ...
7 years, 2 months ago (2013-10-22 17:08:33 UTC) #4
nyquist
lgtm for my user
7 years, 2 months ago (2013-10-22 17:13:59 UTC) #5
gone
Ditto lgtm for myself.
7 years, 2 months ago (2013-10-22 17:18:47 UTC) #6
shashi
lgtm
7 years, 2 months ago (2013-10-22 17:27:21 UTC) #7
frankf
lgtm
7 years, 2 months ago (2013-10-22 17:37:42 UTC) #8
craigdh
lgtm
7 years, 2 months ago (2013-10-22 17:51:18 UTC) #9
aruslan
lgtm for myself
7 years, 2 months ago (2013-10-22 22:49:21 UTC) #10
Ted C
On 2013/10/22 22:49:21, aruslan wrote: > lgtm for myself lgtm
7 years, 2 months ago (2013-10-22 22:50:59 UTC) #11
bulach
lgtm
7 years, 2 months ago (2013-10-23 10:25:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/26880007/38001
7 years, 2 months ago (2013-10-23 10:29:51 UTC) #13
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 13:48:19 UTC) #14
Message was sent while issue was closed.
Change committed as 230400

Powered by Google App Engine
This is Rietveld 408576698