Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2687963003: [dart:io] flush() stdin before close()ing (Closed)

Created:
3 years, 10 months ago by zra
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, kustermann
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io] flush() stdin before close()ing Calls to close() on an IOSink do not imply that writes buffered by the underlying StreamConsumer have been flushed. This CL adds a note indicating this to the IOSink docs, and adds calls to flush() before calls to close() for some calls to stdin.close() for spawned processes in our tests. related #28737 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/8a9a98073f20cca85999e761a90359088a3da375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M pkg/testing/lib/src/stdio_process.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/io/io_sink.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/standalone/io/named_pipe_script_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/process_detached_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_stderr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_stdout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/stdin_sync_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/android.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 10 months ago (2017-02-10 17:32:13 UTC) #2
Florian Schneider
Lgtm
3 years, 10 months ago (2017-02-10 17:43:29 UTC) #3
zra
3 years, 10 months ago (2017-02-10 17:55:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a9a98073f20cca85999e761a90359088a3da375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698