Abstract out ThreadDebugger from V8PerIsolateData

third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
index 5e933530022c1135788a84e4aaea4045c817d768..34e4d98f2e805181c19c3589b31f573e29da3977 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
@@ -26,6 +26,8 @@
 #ifndef V8PerIsolateData_h
 #define V8PerIsolateData_h
 
+#include <v8.h>
+#include <memory>
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ScriptWrappableVisitor.h"
@@ -38,15 +40,12 @@
 #include "wtf/HashMap.h"
 #include "wtf/Noncopyable.h"
 #include "wtf/Vector.h"
-#include <memory>
-#include <v8.h>
 
 namespace blink {
 
 class ActiveScriptWrappableBase;
 class DOMDataStore;
 class StringCache;
-class ThreadDebugger;
 class V8PrivateProperty;
 class WebTaskRunner;
 struct WrapperTypeInfo;
@@ -90,6 +89,11 @@ class CORE_EXPORT V8PerIsolateData {
     const bool m_originalUseCounterDisabled;
   };
 
+  class CORE_EXPORT Data {

[haraken, 2017/02/16 00:27:10]

Add a comment and explain when this class should be used.

[adithyas, 2017/02/16 15:18:04]

Done.

+   public:
+    virtual ~Data(){};

[jbroman, 2017/02/15 18:39:09]

super-nit: no semicolon after a function definition, and prefer a space before
the {. i.e., either:

virtual ~Data() {}

or

virtual ~Data() = default;

(like base/supports_user_data.h)

[adithyas, 2017/02/16 15:18:04]

Fixed.

+  };
+
   static v8::Isolate* initialize(WebTaskRunner*);
 
   static V8PerIsolateData* from(v8::Isolate* isolate) {
@@ -159,8 +163,8 @@ class CORE_EXPORT V8PerIsolateData {
   void runEndOfScopeTasks();
   void clearEndOfScopeTasks();
 
-  void setThreadDebugger(std::unique_ptr<ThreadDebugger>);
-  ThreadDebugger* threadDebugger();
+  void setThreadDebugger(std::unique_ptr<Data>);
+  Data* threadDebugger();
 
   using ActiveScriptWrappableSet =
       HeapHashSet<WeakMember<ActiveScriptWrappableBase>>;
@@ -246,7 +250,7 @@ class CORE_EXPORT V8PerIsolateData {
   bool m_isReportingException;
 
   Vector<std::unique_ptr<EndOfScopeTask>> m_endOfScopeTasks;
-  std::unique_ptr<ThreadDebugger> m_threadDebugger;
+  std::unique_ptr<Data> m_threadDebugger;
 
   Persistent<ActiveScriptWrappableSet> m_activeScriptWrappables;
   std::unique_ptr<ScriptWrappableVisitor> m_scriptWrappableVisitor;