Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2687943004: Abstract out ThreadDebugger from V8PerIsolateData (Closed)
Patch Set: Initialize HiddenValue and PrivateProperty in V8Initializer Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
index 1c99e565a0b888ca98cf127feab3cfb59a3e6be8..401247f39d0a1b69d4a69edf3235dadc8e3f81b8 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -25,21 +25,18 @@
#include "bindings/core/v8/V8PerIsolateData.h"
+#include <v8-debug.h>
+#include <memory>
#include "bindings/core/v8/DOMDataStore.h"
-#include "bindings/core/v8/ScriptSourceCode.h"
#include "bindings/core/v8/V8Binding.h"
-#include "bindings/core/v8/V8HiddenValue.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
-#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/core/v8/V8ScriptRunner.h"
#include "core/frame/Deprecation.h"
-#include "core/inspector/MainThreadDebugger.h"
#include "platform/ScriptForbiddenScope.h"
+#include "platform/WebTaskRunner.h"
#include "public/platform/Platform.h"
#include "wtf/LeakAnnotations.h"
#include "wtf/PtrUtil.h"
-#include <memory>
-#include <v8-debug.h>
namespace blink {
@@ -60,8 +57,6 @@ V8PerIsolateData::V8PerIsolateData(WebTaskRunner* taskRunner)
isMainThread() ? gin::IsolateHolder::kDisallowAtomicsWait
: gin::IsolateHolder::kAllowAtomicsWait)),
m_stringCache(WTF::wrapUnique(new StringCache(isolate()))),
- m_hiddenValue(V8HiddenValue::create()),
- m_privateProperty(V8PrivateProperty::create()),
m_constructorMode(ConstructorMode::CreateNewObject),
m_useCounterDisabled(false),
m_isHandlingRecursionLevelError(false),
@@ -391,16 +386,6 @@ void V8PerIsolateData::clearEndOfScopeTasks() {
m_endOfScopeTasks.clear();
}
-void V8PerIsolateData::setThreadDebugger(
- std::unique_ptr<ThreadDebugger> threadDebugger) {
- ASSERT(!m_threadDebugger);
- m_threadDebugger = std::move(threadDebugger);
-}
-
-ThreadDebugger* V8PerIsolateData::threadDebugger() {
- return m_threadDebugger.get();
-}
-
void V8PerIsolateData::addActiveScriptWrappable(
ActiveScriptWrappableBase* wrappable) {
if (!m_activeScriptWrappables)

Powered by Google App Engine
This is Rietveld 408576698