third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp - Issue 2687943004: Abstract out ThreadDebugger from V8PerIsolateData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

Issue 2687943004: Abstract out ThreadDebugger from V8PerIsolateData (Closed)

Patch Set: Initialize HiddenValue and PrivateProperty in V8Initializer Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

index b04f27386a8bf845f64c78a63825dceafd4ffc9a..8d5f7618ea6359bf68209a82007185ec24063988 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

@@ -12,8 +12,7 @@ namespace blink {

#define V8_DEFINE_METHOD(name) \

v8::Local<v8::String> V8HiddenValue::name(v8::Isolate* isolate) { \

- V8HiddenValue* hiddenValue = \

- V8PerIsolateData::from(isolate)->hiddenValue(); \

+ V8HiddenValue* hiddenValue = from(isolate); \

if (hiddenValue->m_##name.isEmpty()) { \

hiddenValue->m_##name.set(isolate, v8AtomicString(isolate, #name)); \

} \