Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 2687943004: Abstract out ThreadDebugger from V8PerIsolateData (Closed)
Patch Set: Fix style, add comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
index 6d49f1f590466978ce8276c9e798ec15d6f59bd3..18421c7a1d3ca964c74fa1e93087dea480bfbfa6 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
@@ -5,16 +5,17 @@
#ifndef ThreadDebugger_h
#define ThreadDebugger_h
+#include <v8-inspector.h>
+#include <v8-profiler.h>
+#include <v8.h>
+#include <memory>
+#include "bindings/core/v8/V8PerIsolateData.h"
#include "core/CoreExport.h"
#include "core/inspector/ConsoleTypes.h"
#include "platform/Timer.h"
#include "platform/UserGestureIndicator.h"
#include "wtf/Forward.h"
#include "wtf/Vector.h"
-#include <memory>
-#include <v8-inspector.h>
-#include <v8-profiler.h>
-#include <v8.h>
namespace blink {
@@ -22,7 +23,8 @@ class ExecutionContext;
class SourceLocation;
// TODO(dgozman): rename this to ThreadInspector (and subclasses).
-class CORE_EXPORT ThreadDebugger : public v8_inspector::V8InspectorClient {
+class CORE_EXPORT ThreadDebugger : public v8_inspector::V8InspectorClient,
+ public V8PerIsolateData::Data {
WTF_MAKE_NONCOPYABLE(ThreadDebugger);
public:

Powered by Google App Engine
This is Rietveld 408576698