Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 2687943004: Abstract out ThreadDebugger from V8PerIsolateData (Closed)
Patch Set: Fix style, add comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
index 3762d024a60ce863d51300de03e0e4fe4af44b72..dc94cf4b3469204149dc03ff3a661378b6c11efd 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
@@ -34,7 +34,6 @@
#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/core/v8/V8ScriptRunner.h"
#include "bindings/core/v8/V8ValueCache.h"
-#include "core/inspector/MainThreadDebugger.h"
#include "platform/ScriptForbiddenScope.h"
#include "public/platform/Platform.h"
#include "wtf/LeakAnnotations.h"
@@ -267,12 +266,12 @@ void V8PerIsolateData::clearEndOfScopeTasks() {
}
void V8PerIsolateData::setThreadDebugger(
- std::unique_ptr<ThreadDebugger> threadDebugger) {
+ std::unique_ptr<V8PerIsolateData::Data> threadDebugger) {
ASSERT(!m_threadDebugger);
m_threadDebugger = std::move(threadDebugger);
}
-ThreadDebugger* V8PerIsolateData::threadDebugger() {
+V8PerIsolateData::Data* V8PerIsolateData::threadDebugger() {
return m_threadDebugger.get();
}

Powered by Google App Engine
This is Rietveld 408576698