Abstract out ThreadDebugger from V8PerIsolateData

third_party/WebKit/Source/core/inspector/ThreadDebugger.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ThreadDebugger_h
 #define ThreadDebugger_h
 
+#include <v8-inspector.h>
+#include <v8-profiler.h>
+#include <v8.h>
+#include <memory>
+#include "bindings/core/v8/V8PerIsolateData.h"
 #include "core/CoreExport.h"
 #include "core/inspector/ConsoleTypes.h"
 #include "platform/Timer.h"
 #include "platform/UserGestureIndicator.h"
 #include "wtf/Forward.h"
 #include "wtf/Vector.h"
-#include <memory>
-#include <v8-inspector.h>
-#include <v8-profiler.h>
-#include <v8.h>
 
 namespace blink {
 
 class ExecutionContext;
 class SourceLocation;
 
 // TODO(dgozman): rename this to ThreadInspector (and subclasses).
-class CORE_EXPORT ThreadDebugger : public v8_inspector::V8InspectorClient {
+class CORE_EXPORT ThreadDebugger : public v8_inspector::V8InspectorClient,
+                                   public V8PerIsolateData::Data {
   WTF_MAKE_NONCOPYABLE(ThreadDebugger);
 
  public:
   explicit ThreadDebugger(v8::Isolate*);
   ~ThreadDebugger() override;
 
   static ThreadDebugger* from(v8::Isolate*);
   virtual bool isWorker() = 0;
   v8_inspector::V8Inspector* v8Inspector() const { return m_v8Inspector.get(); }
 
+  static void setThreadDebugger(v8::Isolate*, ThreadDebugger*);
+  static ThreadDebugger* getThreadDebugger(v8::Isolate*);

[jbroman, 2017/02/15 02:25:23]

This looks equivalent to ThreadDebugger::from, above.

[adithyas, 2017/02/15 18:12:12]

Yup, don't know why I added this.

+
   static void willExecuteScript(v8::Isolate*, int scriptId);
   static void didExecuteScript(v8::Isolate*);
   static void idleStarted(v8::Isolate*);
   static void idleFinished(v8::Isolate*);
 
   void asyncTaskScheduled(const String& taskName, void* task, bool recurring);
   void asyncTaskCanceled(void* task);
   void allAsyncTasksCanceled();
   void asyncTaskStarted(void* task);
   void asyncTaskFinished(void* task);
@@ skipping 60 matching lines @@
   std::unique_ptr<v8::TracingCpuProfiler> m_v8TracingCpuProfiler;
   Vector<std::unique_ptr<Timer<ThreadDebugger>>> m_timers;
   Vector<v8_inspector::V8InspectorClient::TimerCallback> m_timerCallbacks;
   Vector<void*> m_timerData;
   std::unique_ptr<UserGestureIndicator> m_userGestureIndicator;
 };
 
 }  // namespace blink
 
 #endif  // ThreadDebugger_h