Abstract out ThreadDebugger from V8PerIsolateData

third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8HiddenValue_h
 #define V8HiddenValue_h
 
+#include <v8.h>
+#include <memory>
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "bindings/core/v8/ScriptPromiseProperties.h"
+#include "bindings/core/v8/V8PerIsolateData.h"
 #include "core/CoreExport.h"
 #include "wtf/Allocator.h"
 #include "wtf/PtrUtil.h"
-#include <memory>
-#include <v8.h>
 
 namespace blink {
 
 class ScriptState;
 class ScriptWrappable;
 
 #define V8_HIDDEN_VALUES(V)                  \
   V(customElementAttachedCallback)           \
   V(customElementAttributeChangedCallback)   \
   V(customElementCreatedCallback)            \
@@ skipping 12 matching lines @@
   V(port2)                                   \
   V(requestInFetchEvent)                     \
   V(state)                                   \
   V(testInterfaces)                          \
   V(thenableHiddenPromise)                   \
   V(toStringString)                          \
   V(injectedScriptNative)                    \
   SCRIPT_PROMISE_PROPERTIES(V, Promise)      \
   SCRIPT_PROMISE_PROPERTIES(V, Resolver)
 
-class CORE_EXPORT V8HiddenValue {
+class CORE_EXPORT V8HiddenValue : public V8PerIsolateData::Data {
   USING_FAST_MALLOC(V8HiddenValue);
   WTF_MAKE_NONCOPYABLE(V8HiddenValue);
 
  public:
-  static std::unique_ptr<V8HiddenValue> create() {
-    return WTF::wrapUnique(new V8HiddenValue());
+  static void initialize(v8::Isolate* isolate) {
+    V8PerIsolateData::from(isolate)->setHiddenValue(new V8HiddenValue());
+  }
+  static V8HiddenValue* from(v8::Isolate* isolate) {

[Yuki, 2017/02/15 10:00:40]

No need to expose this method as public:, I think.
Should be private:.

+    return static_cast<V8HiddenValue*>(
+        V8PerIsolateData::from(isolate)->hiddenValue());
   }
 
 #define V8_DECLARE_METHOD(name) \
   static v8::Local<v8::String> name(v8::Isolate* isolate);
   V8_HIDDEN_VALUES(V8_DECLARE_METHOD);
 #undef V8_DECLARE_METHOD
 
   static v8::Local<v8::Value> getHiddenValue(ScriptState*,
                                              v8::Local<v8::Object>,
                                              v8::Local<v8::String>);
@@ skipping 13 matching lines @@
   V8HiddenValue() {}
 
 #define V8_DECLARE_FIELD(name) ScopedPersistent<v8::String> m_##name;
   V8_HIDDEN_VALUES(V8_DECLARE_FIELD);
 #undef V8_DECLARE_FIELD
 };
 
 }  // namespace blink
 
 #endif  // V8HiddenValue_h