Pepper: Move DoPostMessage out of trusted plugin.

Pepper: Move DoPostMessage out of trusted plugin.

This is the first effort at moving some of the ReverseService logic out of the
trusted plugin. I'd like to move these over soon since the tangled callback is
pretty nasty, and hidehiko@ has run into the ugliness while adding features for
Bare Metal Mode.

This one is pretty easy since it's stateless.

BUG=239656
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269480

[teravest, 2014-05-06 20:11:46]

Bill,

Mind taking a look at this one?

[bbudge, 2014-05-06 20:48:19]

LGTM w/comment-question

https://codereview.chromium.org/268793002/diff/90001/ppapi/api/private/ppb_na...
File ppapi/api/private/ppb_nacl_private.idl (right):

https://codereview.chromium.org/268793002/diff/90001/ppapi/api/private/ppb_na...
ppapi/api/private/ppb_nacl_private.idl:448: [in] str_t message);
Are you using str_t here to make usage simpler? In the implementation you have
to convert this back into a PP_Var to send over the MessageChannel. I guess this
is the logical choice unless other call sites would already have constructed a
PP_Var. I only see a single call, in service_runtime.cc.

[teravest, 2014-05-06 20:51:13]

On Tue, May 6, 2014 at 2:48 PM,  <bbudge@chromium.org> wrote:
> LGTM w/comment-question
>
>
>
https://codereview.chromium.org/268793002/diff/90001/ppapi/api/private/ppb_na...
> File ppapi/api/private/ppb_nacl_private.idl (right):
>
>
https://codereview.chromium.org/268793002/diff/90001/ppapi/api/private/ppb_na...
> ppapi/api/private/ppb_nacl_private.idl:448: [in] str_t message);
> Are you using str_t here to make usage simpler? In the implementation
> you have to convert this back into a PP_Var to send over the
> MessageChannel. I guess this is the logical choice unless other call
> sites would already have constructed a PP_Var. I only see a single call,
> in service_runtime.cc.

That's correct, I just did this for simplicity since there's only one
user, and it's posting a string.
That said, it'd be pretty easy for me to convert it to a var in the
trusted plugin if you'd prefer that.

>
> https://codereview.chromium.org/268793002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[bbudge, 2014-05-06 20:52:48]

On 2014/05/06 20:51:13, teravest wrote:
> On Tue, May 6, 2014 at 2:48 PM,  <mailto:bbudge@chromium.org> wrote:
> > LGTM w/comment-question
> >
> >
> >
>
https://codereview.chromium.org/268793002/diff/90001/ppapi/api/private/ppb_na...
> > File ppapi/api/private/ppb_nacl_private.idl (right):
> >
> >
>
https://codereview.chromium.org/268793002/diff/90001/ppapi/api/private/ppb_na...
> > ppapi/api/private/ppb_nacl_private.idl:448: [in] str_t message);
> > Are you using str_t here to make usage simpler? In the implementation
> > you have to convert this back into a PP_Var to send over the
> > MessageChannel. I guess this is the logical choice unless other call
> > sites would already have constructed a PP_Var. I only see a single call,
> > in service_runtime.cc.
> 
> That's correct, I just did this for simplicity since there's only one
> user, and it's posting a string.
> That said, it'd be pretty easy for me to convert it to a var in the
> trusted plugin if you'd prefer that.
> 
> >
> > https://codereview.chromium.org/268793002/
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

It's fine. The goal is to move code out of the plugin after all.

[teravest, 2014-05-08 16:26:51]

+avi for content/public/renderer/pepper_plugin_instance.h

[Avi (use Gerrit), 2014-05-08 18:46:57]

lgtm

Sure!

[teravest, 2014-05-09 00:13:47]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-05-09 00:16:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/teravest@chromium.org/268793002/130001

[commit-bot: I haz the power, 2014-05-10 02:01:31]

Change committed as 269480