Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2687883002: Do not invoke fatal in dart:_internal when fuzzing mirrors (Closed)

Created:
3 years, 10 months ago by Kevin Millikin (Google)
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not invoke fatal in dart:_internal when fuzzing mirrors Add fatal from dart:_internal to the blacklist of functions we should not invoke while fuzzing mirrors. Invoking it will not succeed. Arguably, mirrors should not be able to see any of the members of dart:_internal but that's a bigger implementation change and possibly a breaking change. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/508793071a156d1f1f0c9a7336c4ad33cd9d2305

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Kevin Millikin (Google)
3 years, 10 months ago (2017-02-09 13:02:53 UTC) #2
Kevin Millikin (Google)
+kustermann
3 years, 10 months ago (2017-02-09 13:07:25 UTC) #4
kustermann
lgtm
3 years, 10 months ago (2017-02-09 13:08:18 UTC) #5
Kevin Millikin (Google)
3 years, 10 months ago (2017-02-09 13:08:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
508793071a156d1f1f0c9a7336c4ad33cd9d2305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698