Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h

Issue 2687853002: Switching VirtualKeyboardPrivate keyboard config call stack to receive HasInputDevices() responce a… (Closed)
Patch Set: Fix for compilation error on linux_chromium_chromeos Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h
diff --git a/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h b/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h
index 62b54f3d85ed774601460330827a1d0a2fe869a4..7b3bcb19b279a05709a4bcced103774d1f3fe364 100644
--- a/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h
+++ b/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h
@@ -5,6 +5,7 @@
#ifndef EXTENSIONS_BROWSER_API_VIRTUAL_KEYBOARD_PRIVATE_VIRTUAL_KEYBOARD_DELEGATE_H_
#define EXTENSIONS_BROWSER_API_VIRTUAL_KEYBOARD_PRIVATE_VIRTUAL_KEYBOARD_DELEGATE_H_
+#include "base/callback.h"
#include "base/macros.h"
#include "base/strings/string16.h"
#include "base/values.h"
@@ -16,10 +17,14 @@ class VirtualKeyboardDelegate {
public:
virtual ~VirtualKeyboardDelegate() {}
+ using OnKeyboardSettingsCallback =
+ base::Callback<void(std::unique_ptr<base::DictionaryValue> settings)>;
+
// Fetch information about the preferred configuration of the keyboard. On
- // exit, |settings| is populated with the keyboard configuration. Returns true
- // if successful.
- virtual bool GetKeyboardConfig(base::DictionaryValue* settings) = 0;
+ // exit, |settings| is populated with the keyboard configuration if execution
+ // is successful, otherwise it's set to nullptr.
+ virtual void GetKeyboardConfig(
+ OnKeyboardSettingsCallback on_settings_callback) = 0;
// Dismiss the virtual keyboard without changing input focus. Returns true if
// successful.

Powered by Google App Engine
This is Rietveld 408576698