Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4510)

Unified Diff: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h

Issue 2687853002: Switching VirtualKeyboardPrivate keyboard config call stack to receive HasInputDevices() responce a… (Closed)
Patch Set: Fix for compilation error on linux_chromium_chromeos Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h
diff --git a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h
index f52f458657d759ed887c4486184f1d9736c74f32..0d08b1a5b87537924cb31d5e4512d1c99c0bcd65 100644
--- a/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h
+++ b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h
@@ -7,15 +7,18 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
#include "extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h"
namespace extensions {
class ChromeVirtualKeyboardDelegate : public VirtualKeyboardDelegate {
public:
- ChromeVirtualKeyboardDelegate() {}
- ~ChromeVirtualKeyboardDelegate() override {}
- bool GetKeyboardConfig(base::DictionaryValue* settings) override;
+ ChromeVirtualKeyboardDelegate();
+ ~ChromeVirtualKeyboardDelegate() override;
+
+ void GetKeyboardConfig(
+ OnKeyboardSettingsCallback on_settings_callback) override;
bool HideKeyboard() override;
bool InsertText(const base::string16& text) override;
bool OnKeyboardLoaded() override;
@@ -32,6 +35,11 @@ class ChromeVirtualKeyboardDelegate : public VirtualKeyboardDelegate {
bool SetRequestedKeyboardState(int state_enum) override;
private:
+ void OnHasInputDevices(OnKeyboardSettingsCallback on_settings_callback,
+ bool has_input_devices);
+
+ base::WeakPtr<ChromeVirtualKeyboardDelegate> weak_this_;
+ base::WeakPtrFactory<ChromeVirtualKeyboardDelegate> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(ChromeVirtualKeyboardDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698