Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: Source/core/page/Performance.h

Issue 26878003: Reduce repetitive EventTarget subclassing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nit Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/EventSource.cpp ('k') | Source/core/page/Performance.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/Performance.h
diff --git a/Source/core/page/Performance.h b/Source/core/page/Performance.h
index b222b49a04063b075e07dd52875beb672c1e955f..6d01b7ceb99cd0359ab646efc570461d3165dfc3 100644
--- a/Source/core/page/Performance.h
+++ b/Source/core/page/Performance.h
@@ -53,13 +53,13 @@ class ResourceResponse;
class ResourceTimingInfo;
class UserTiming;
-class Performance : public ScriptWrappable, public RefCounted<Performance>, public DOMWindowProperty, public EventTarget {
+class Performance : public ScriptWrappable, public RefCounted<Performance>, public DOMWindowProperty, public EventTargetWithInlineData {
public:
static PassRefPtr<Performance> create(Frame* frame) { return adoptRef(new Performance(frame)); }
~Performance();
- virtual const AtomicString& interfaceName() const;
- virtual ScriptExecutionContext* scriptExecutionContext() const;
+ virtual const AtomicString& interfaceName() const OVERRIDE;
+ virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE;
PassRefPtr<MemoryInfo> memory() const;
PerformanceNavigation* navigation() const;
@@ -89,15 +89,12 @@ public:
private:
explicit Performance(Frame*);
- virtual void refEventTarget() { ref(); }
- virtual void derefEventTarget() { deref(); }
- virtual EventTargetData* eventTargetData();
- virtual EventTargetData* ensureEventTargetData();
+ virtual void refEventTarget() OVERRIDE { ref(); }
+ virtual void derefEventTarget() OVERRIDE { deref(); }
+
bool isResourceTimingBufferFull();
void addResourceTimingBuffer(PassRefPtr<PerformanceEntry>);
- EventTargetData m_eventTargetData;
-
mutable RefPtr<PerformanceNavigation> m_navigation;
mutable RefPtr<PerformanceTiming> m_timing;
« no previous file with comments | « Source/core/page/EventSource.cpp ('k') | Source/core/page/Performance.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698