Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: Source/core/html/track/TrackBase.h

Issue 26878003: Reduce repetitive EventTarget subclassing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nit Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/TextTrackList.h ('k') | Source/core/html/track/TrackBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TrackBase.h
diff --git a/Source/core/html/track/TrackBase.h b/Source/core/html/track/TrackBase.h
index 41e5a5b24fd55a1e91196efe70184d2cfc9d81d6..1faf0c7b00e1d82d66ca2d5f168b0ce9cd956574 100644
--- a/Source/core/html/track/TrackBase.h
+++ b/Source/core/html/track/TrackBase.h
@@ -33,15 +33,15 @@ namespace WebCore {
class ScriptExecutionContext;
-class TrackBase : public RefCounted<TrackBase>, public EventTarget {
+class TrackBase : public RefCounted<TrackBase>, public EventTargetWithInlineData {
public:
virtual ~TrackBase();
enum Type { BaseTrack, TextTrack, AudioTrack, VideoTrack };
Type type() const { return m_type; }
- virtual const AtomicString& interfaceName() const;
- virtual ScriptExecutionContext* scriptExecutionContext() const;
+ virtual const AtomicString& interfaceName() const OVERRIDE;
+ virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE;
using RefCounted<TrackBase>::ref;
using RefCounted<TrackBase>::deref;
@@ -49,17 +49,13 @@ public:
protected:
TrackBase(ScriptExecutionContext*, Type);
- virtual EventTargetData* eventTargetData();
- virtual EventTargetData* ensureEventTargetData();
-
private:
Type m_type;
- virtual void refEventTarget() { ref(); }
- virtual void derefEventTarget() { deref(); }
+ virtual void refEventTarget() OVERRIDE { ref(); }
+ virtual void derefEventTarget() OVERRIDE { deref(); }
ScriptExecutionContext* m_scriptExecutionContext;
- EventTargetData m_eventTargetData;
};
} // namespace WebCore
« no previous file with comments | « Source/core/html/track/TextTrackList.h ('k') | Source/core/html/track/TrackBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698