Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 26878003: Reduce repetitive EventTarget subclassing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nit Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/MediaController.h ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index 518de2cd725e6fc61b9bbd49d3745b9b724123a8..d878ad456a354fbb863a036a5ba01021c5a67f68 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -69,7 +69,7 @@ protected:
// ----------------------------
-class TextTrackCue : public RefCounted<TextTrackCue>, public ScriptWrappable, public EventTarget {
+class TextTrackCue : public RefCounted<TextTrackCue>, public ScriptWrappable, public EventTargetWithInlineData {
public:
static PassRefPtr<TextTrackCue> create(ScriptExecutionContext* context, double start, double end, const String& content)
{
@@ -150,8 +150,8 @@ public:
int calculateComputedLinePosition();
- virtual const AtomicString& interfaceName() const;
- virtual ScriptExecutionContext* scriptExecutionContext() const;
+ virtual const AtomicString& interfaceName() const OVERRIDE;
+ virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE;
std::pair<double, double> getCSSPosition() const;
@@ -199,9 +199,6 @@ public:
using RefCounted<TextTrackCue>::deref;
protected:
- virtual EventTargetData* eventTargetData();
- virtual EventTargetData* ensureEventTargetData();
-
TextTrackCue(ScriptExecutionContext*, double start, double end, const String& content);
Document* ownerDocument() { return toDocument(m_scriptExecutionContext); }
@@ -222,8 +219,8 @@ private:
void cueWillChange();
void cueDidChange();
- virtual void refEventTarget() { ref(); }
- virtual void derefEventTarget() { deref(); }
+ virtual void refEventTarget() OVERRIDE { ref(); }
+ virtual void derefEventTarget() OVERRIDE { deref(); }
enum CueSetting {
None,
@@ -256,7 +253,6 @@ private:
RefPtr<DocumentFragment> m_webVTTNodeTree;
TextTrack* m_track;
- EventTargetData m_eventTargetData;
ScriptExecutionContext* m_scriptExecutionContext;
bool m_isActive;
« no previous file with comments | « Source/core/html/MediaController.h ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698