Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: Source/core/css/FontFaceSet.h

Issue 26878003: Reduce repetitive EventTarget subclassing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nit Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/FontFaceSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/FontFaceSet.h
diff --git a/Source/core/css/FontFaceSet.h b/Source/core/css/FontFaceSet.h
index 5ce70edf4f732818f26faa37a69d053d01ebe699..fa60c9c9475a961eb91b2f2d6de16d980ce57eb3 100644
--- a/Source/core/css/FontFaceSet.h
+++ b/Source/core/css/FontFaceSet.h
@@ -55,7 +55,7 @@ class FontsReadyPromiseResolver;
class LoadFontPromiseResolver;
class ScriptExecutionContext;
-class FontFaceSet : public RefCounted<FontFaceSet>, public ActiveDOMObject, public EventTarget {
+class FontFaceSet : public RefCounted<FontFaceSet>, public ActiveDOMObject, public EventTargetWithInlineData {
public:
static PassRefPtr<FontFaceSet> create(Document* document)
{
@@ -74,8 +74,8 @@ public:
AtomicString status() const;
- virtual ScriptExecutionContext* scriptExecutionContext() const;
- virtual const AtomicString& interfaceName() const;
+ virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE;
+ virtual const AtomicString& interfaceName() const OVERRIDE;
using RefCounted<FontFaceSet>::ref;
using RefCounted<FontFaceSet>::deref;
@@ -102,10 +102,8 @@ private:
FontFaceSet(Document*);
- virtual void refEventTarget() { ref(); }
- virtual void derefEventTarget() { deref(); }
- virtual EventTargetData* eventTargetData();
- virtual EventTargetData* ensureEventTargetData();
+ virtual void refEventTarget() OVERRIDE { ref(); }
+ virtual void derefEventTarget() OVERRIDE { deref(); }
void scheduleEvent(PassRefPtr<Event>);
void queueDoneEvent(FontFace*);
@@ -115,7 +113,6 @@ private:
bool resolveFontStyle(const String&, Font&);
void timerFired(Timer<FontFaceSet>*);
- EventTargetData m_eventTargetData;
unsigned m_loadingCount;
Vector<RefPtr<Event> > m_pendingEvents;
Vector<RefPtr<LoadFontPromiseResolver> > m_pendingLoadResolvers;
« no previous file with comments | « no previous file | Source/core/css/FontFaceSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698