Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: Source/modules/webmidi/MIDIPort.h

Issue 26878003: Reduce repetitive EventTarget subclassing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nit Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/modules/webmidi/MIDIAccess.h ('k') | Source/modules/websockets/WebSocket.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 22 matching lines...) Expand all
33 33
34 #include "bindings/v8/ScriptWrappable.h" 34 #include "bindings/v8/ScriptWrappable.h"
35 #include "core/dom/ActiveDOMObject.h" 35 #include "core/dom/ActiveDOMObject.h"
36 #include "core/events/EventTarget.h" 36 #include "core/events/EventTarget.h"
37 #include "wtf/RefCounted.h" 37 #include "wtf/RefCounted.h"
38 #include "wtf/RefPtr.h" 38 #include "wtf/RefPtr.h"
39 #include "wtf/Vector.h" 39 #include "wtf/Vector.h"
40 40
41 namespace WebCore { 41 namespace WebCore {
42 42
43 class MIDIPort : public RefCounted<MIDIPort>, public ScriptWrappable, public Act iveDOMObject, public EventTarget { 43 class MIDIPort : public RefCounted<MIDIPort>, public ScriptWrappable, public Act iveDOMObject, public EventTargetWithInlineData {
44 public: 44 public:
45 enum MIDIPortTypeCode { 45 enum MIDIPortTypeCode {
46 MIDIPortTypeInput, 46 MIDIPortTypeInput,
47 MIDIPortTypeOutput 47 MIDIPortTypeOutput
48 }; 48 };
49 49
50 static PassRefPtr<MIDIPort> create(ScriptExecutionContext*, const String& id , const String& manufacturer, const String& name, MIDIPortTypeCode, const String & version); 50 static PassRefPtr<MIDIPort> create(ScriptExecutionContext*, const String& id , const String& manufacturer, const String& name, MIDIPortTypeCode, const String & version);
51 virtual ~MIDIPort(); 51 virtual ~MIDIPort();
52 52
53 String id() const { return m_id; } 53 String id() const { return m_id; }
(...skipping 14 matching lines...) Expand all
68 // ActiveDOMObject 68 // ActiveDOMObject
69 virtual bool canSuspend() const OVERRIDE { return true; } 69 virtual bool canSuspend() const OVERRIDE { return true; }
70 70
71 protected: 71 protected:
72 MIDIPort(ScriptExecutionContext*, const String& id, const String& manufactur er, const String& name, MIDIPortTypeCode, const String& version); 72 MIDIPort(ScriptExecutionContext*, const String& id, const String& manufactur er, const String& name, MIDIPortTypeCode, const String& version);
73 73
74 private: 74 private:
75 // EventTarget 75 // EventTarget
76 virtual void refEventTarget() OVERRIDE { ref(); } 76 virtual void refEventTarget() OVERRIDE { ref(); }
77 virtual void derefEventTarget() OVERRIDE { deref(); } 77 virtual void derefEventTarget() OVERRIDE { deref(); }
78 virtual EventTargetData* eventTargetData() OVERRIDE { return &m_eventTargetD ata; }
79 virtual EventTargetData* ensureEventTargetData() OVERRIDE { return &m_eventT argetData; }
80 78
81 String m_id; 79 String m_id;
82 String m_manufacturer; 80 String m_manufacturer;
83 String m_name; 81 String m_name;
84 MIDIPortTypeCode m_type; 82 MIDIPortTypeCode m_type;
85 String m_version; 83 String m_version;
86 EventTargetData m_eventTargetData;
87 }; 84 };
88 85
89 typedef Vector<RefPtr<MIDIPort> > MIDIPortVector; 86 typedef Vector<RefPtr<MIDIPort> > MIDIPortVector;
90 87
91 } // namespace WebCore 88 } // namespace WebCore
92 89
93 #endif // MIDIPort_h 90 #endif // MIDIPort_h
OLDNEW
« no previous file with comments | « Source/modules/webmidi/MIDIAccess.h ('k') | Source/modules/websockets/WebSocket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698