Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: Source/modules/mediasource/WebKitSourceBufferList.h

Issue 26878003: Reduce repetitive EventTarget subclassing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nit Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 23 matching lines...) Expand all
34 #include "bindings/v8/ScriptWrappable.h" 34 #include "bindings/v8/ScriptWrappable.h"
35 #include "core/events/EventTarget.h" 35 #include "core/events/EventTarget.h"
36 #include "wtf/RefCounted.h" 36 #include "wtf/RefCounted.h"
37 #include "wtf/Vector.h" 37 #include "wtf/Vector.h"
38 38
39 namespace WebCore { 39 namespace WebCore {
40 40
41 class WebKitSourceBuffer; 41 class WebKitSourceBuffer;
42 class GenericEventQueue; 42 class GenericEventQueue;
43 43
44 class WebKitSourceBufferList : public RefCounted<WebKitSourceBufferList>, public ScriptWrappable, public EventTarget { 44 class WebKitSourceBufferList : public RefCounted<WebKitSourceBufferList>, public ScriptWrappable, public EventTargetWithInlineData {
45 public: 45 public:
46 static PassRefPtr<WebKitSourceBufferList> create(ScriptExecutionContext* con text, GenericEventQueue* asyncEventQueue) 46 static PassRefPtr<WebKitSourceBufferList> create(ScriptExecutionContext* con text, GenericEventQueue* asyncEventQueue)
47 { 47 {
48 return adoptRef(new WebKitSourceBufferList(context, asyncEventQueue)); 48 return adoptRef(new WebKitSourceBufferList(context, asyncEventQueue));
49 } 49 }
50 virtual ~WebKitSourceBufferList() { } 50 virtual ~WebKitSourceBufferList() { }
51 51
52 unsigned long length() const; 52 unsigned long length() const;
53 WebKitSourceBuffer* item(unsigned index) const; 53 WebKitSourceBuffer* item(unsigned index) const;
54 54
55 void add(PassRefPtr<WebKitSourceBuffer>); 55 void add(PassRefPtr<WebKitSourceBuffer>);
56 bool remove(WebKitSourceBuffer*); 56 bool remove(WebKitSourceBuffer*);
57 void clear(); 57 void clear();
58 58
59 // EventTarget interface 59 // EventTarget interface
60 virtual const AtomicString& interfaceName() const OVERRIDE; 60 virtual const AtomicString& interfaceName() const OVERRIDE;
61 virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE; 61 virtual ScriptExecutionContext* scriptExecutionContext() const OVERRIDE;
62 62
63 using RefCounted<WebKitSourceBufferList>::ref; 63 using RefCounted<WebKitSourceBufferList>::ref;
64 using RefCounted<WebKitSourceBufferList>::deref; 64 using RefCounted<WebKitSourceBufferList>::deref;
65 65
66 protected:
67 virtual EventTargetData* eventTargetData() OVERRIDE;
68 virtual EventTargetData* ensureEventTargetData() OVERRIDE;
69
70 private: 66 private:
71 WebKitSourceBufferList(ScriptExecutionContext*, GenericEventQueue*); 67 WebKitSourceBufferList(ScriptExecutionContext*, GenericEventQueue*);
72 68
73 void createAndFireEvent(const AtomicString&); 69 void createAndFireEvent(const AtomicString&);
74 70
75 virtual void refEventTarget() OVERRIDE { ref(); } 71 virtual void refEventTarget() OVERRIDE { ref(); }
76 virtual void derefEventTarget() OVERRIDE { deref(); } 72 virtual void derefEventTarget() OVERRIDE { deref(); }
77 73
78 EventTargetData m_eventTargetData;
79 ScriptExecutionContext* m_scriptExecutionContext; 74 ScriptExecutionContext* m_scriptExecutionContext;
80 GenericEventQueue* m_asyncEventQueue; 75 GenericEventQueue* m_asyncEventQueue;
81 76
82 Vector<RefPtr<WebKitSourceBuffer> > m_list; 77 Vector<RefPtr<WebKitSourceBuffer> > m_list;
83 }; 78 };
84 79
85 } // namespace WebCore 80 } // namespace WebCore
86 81
87 #endif 82 #endif
OLDNEW
« no previous file with comments | « Source/modules/mediasource/SourceBufferList.cpp ('k') | Source/modules/mediasource/WebKitSourceBufferList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698