Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Side by Side Diff: Source/core/page/DOMWindow.cpp

Issue 26878003: Reduce repetitive EventTarget subclassing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nit Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/DOMWindow.h ('k') | Source/core/page/EventSource.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1525 matching lines...) Expand 10 before | Expand all | Expand 10 after
1536 } 1536 }
1537 1537
1538 void DOMWindow::finishedLoading() 1538 void DOMWindow::finishedLoading()
1539 { 1539 {
1540 if (m_shouldPrintWhenFinishedLoading) { 1540 if (m_shouldPrintWhenFinishedLoading) {
1541 m_shouldPrintWhenFinishedLoading = false; 1541 m_shouldPrintWhenFinishedLoading = false;
1542 print(); 1542 print();
1543 } 1543 }
1544 } 1544 }
1545 1545
1546 EventTargetData* DOMWindow::eventTargetData()
1547 {
1548 return &m_eventTargetData;
1549 }
1550
1551 EventTargetData* DOMWindow::ensureEventTargetData()
1552 {
1553 return &m_eventTargetData;
1554 }
1555
1556 void DOMWindow::setLocation(const String& urlString, DOMWindow* activeWindow, DO MWindow* firstWindow, SetLocationLocking locking) 1546 void DOMWindow::setLocation(const String& urlString, DOMWindow* activeWindow, DO MWindow* firstWindow, SetLocationLocking locking)
1557 { 1547 {
1558 if (!isCurrentlyDisplayedInFrame()) 1548 if (!isCurrentlyDisplayedInFrame())
1559 return; 1549 return;
1560 1550
1561 Document* activeDocument = activeWindow->document(); 1551 Document* activeDocument = activeWindow->document();
1562 if (!activeDocument) 1552 if (!activeDocument)
1563 return; 1553 return;
1564 1554
1565 if (!activeDocument->canNavigate(m_frame)) 1555 if (!activeDocument->canNavigate(m_frame))
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
1776 return static_cast<DOMWindowLifecycleNotifier*>(LifecycleContext::lifecycleN otifier()); 1766 return static_cast<DOMWindowLifecycleNotifier*>(LifecycleContext::lifecycleN otifier());
1777 } 1767 }
1778 1768
1779 PassOwnPtr<LifecycleNotifier> DOMWindow::createLifecycleNotifier() 1769 PassOwnPtr<LifecycleNotifier> DOMWindow::createLifecycleNotifier()
1780 { 1770 {
1781 return DOMWindowLifecycleNotifier::create(this); 1771 return DOMWindowLifecycleNotifier::create(this);
1782 } 1772 }
1783 1773
1784 1774
1785 } // namespace WebCore 1775 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/page/DOMWindow.h ('k') | Source/core/page/EventSource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698