Add version info to the eventlog_provider.dll.

base/win/BUILD.gn

Index: base/win/BUILD.gn
diff --git a/base/win/BUILD.gn b/base/win/BUILD.gn
index 74c1b8a0a9c40678c2e447395687f68c49e2c80e..5d3d094ce8b914ac4d60970165d4ee4c5b498dfd 100644
--- a/base/win/BUILD.gn
+++ b/base/win/BUILD.gn
@@ -5,6 +5,7 @@
 import("//build/buildflag_header.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/win/message_compiler.gni")
+import("//chrome/process_version_rc_template.gni")

[veranika, 2017/02/17 19:17:20]

This change makes //base/win depend on //chrome, which doesn't look right to me.
Is there any way to refactor process_version_rc_template.gni out of //chrome?

[grt (UTC plus 2), 2017/02/20 09:26:21]

Agreed. Sorry I missed that. Since logging::SetEventSourceName is called from
chrome/common to fire up the provider for Chrome, maybe the right thing is to
move the provider dll out of base and into chrome itself?

[pastarmovj, 2017/02/20 09:47:01]

I contemplated this for a while when I was adding this in here but I decided the
layering did not stretch to using build tools defined in another layer.

Moving the dll generation to Chrome can be a good choice although it really is
related to the SYSLOG macro defined in base then specific to Chrome.

[grt (UTC plus 2), 2017/02/20 09:53:47]

Hmm. Well, another way to look at it is that adding version info to a DLL or EXE
is a build-ish thing more than a Chrome-ish thing. Can the version template
stuff be moved into src/build without moving Chrome-isms into there?

 
 declare_args() {
   # Indicates if the handle verifier should operate in a single module mode. By
@@ -37,6 +38,14 @@ message_compiler("eventlog_messages") {
   user_mode_logging = false
   compile_generated_code = false
 }
+
+process_version_rc_template("eventlog_provider_dll_version") {
+  sources = [
+    "eventlog_provider.ver",
+  ]
+  output = "$target_gen_dir/eventlog_provider_dll_version.rc"
+}
+
 shared_library("eventlog_provider") {
   sources = [
     "$root_gen_dir/base/win/eventlog_messages.rc",
@@ -49,5 +58,6 @@ shared_library("eventlog_provider") {
 
   deps = [
     "//base/win:eventlog_messages",
+    "//base/win:eventlog_provider_dll_version",
   ]
 }