Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2687723002: Remove hardcoded paths from perf.dart. (Closed)

Created:
3 years, 10 months ago by Paul Berry
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove hardcoded paths from perf.dart. This lets perf.dart find the SDK and the .packages file regardless of the architecture that's being tested and the working directory in which the script is started. Fixes #28676. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9a82ada0858a6b91ffafb8c6832603cda6c06d0c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M pkg/front_end/tool/perf.dart View 6 chunks +32 lines, -6 lines 2 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 10 months ago (2017-02-08 18:24:20 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2687723002/diff/1/pkg/front_end/tool/perf.dart File pkg/front_end/tool/perf.dart (right): https://codereview.chromium.org/2687723002/diff/1/pkg/front_end/tool/perf.dart#newcode132 pkg/front_end/tool/perf.dart:132: // TODO(sigmund): adjust path based on the benchmark ...
3 years, 10 months ago (2017-02-08 22:40:39 UTC) #3
Paul Berry
https://codereview.chromium.org/2687723002/diff/1/pkg/front_end/tool/perf.dart File pkg/front_end/tool/perf.dart (right): https://codereview.chromium.org/2687723002/diff/1/pkg/front_end/tool/perf.dart#newcode132 pkg/front_end/tool/perf.dart:132: // TODO(sigmund): adjust path based on the benchmark runner ...
3 years, 10 months ago (2017-02-09 00:41:50 UTC) #4
Paul Berry
3 years, 10 months ago (2017-02-09 00:48:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a82ada0858a6b91ffafb8c6832603cda6c06d0c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698