Stop base::OpenFile from leaking fds/handles into child procs.

base/files/file_util_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <libgen.h>
@@ skipping 167 matching lines @@
       if (mprotect(mapping, pagesize, PROT_READ | PROT_EXEC) == 0)
         result = true;
       munmap(mapping, pagesize);
     }
   }
   return result;
 }
 #endif  // defined(OS_LINUX)
 #endif  // !defined(OS_NACL_NONSFI)
 
+// Appends |mode_char| to |mode| before the optional character set encoding for
+// non-Mac platforms (which do not support this); see

[Mark Mentovai, 2017/02/09 15:15:16]

Why even bother defining this on Mac? Since you need an #ifdef at the point
where you call this anyway, it doesn’t seem useful to even call it on Mac.

[grt (UTC plus 2), 2017/02/10 09:37:21]

Done.

+// https://www.gnu.org/software/libc/manual/html_node/Opening-Streams.html for
+// details.
+std::string AppendModeCharacter(StringPiece mode, char mode_char) {
+  // Add |mode_char| immediately before the comma or at the end of the string.
+  std::string result(mode.as_string());
+#if !defined(OS_MACOSX)
+  size_t comma_pos = result.find(L',');

[Mark Mentovai, 2017/02/09 15:15:16]

No L

[grt (UTC plus 2), 2017/02/10 09:37:21]

Done.

+  result.insert(comma_pos == std::string::npos ? result.length() : comma_pos, 1,
+                mode_char);
+#endif
+  return result;
+}
+
 }  // namespace
 
 #if !defined(OS_NACL_NONSFI)
 FilePath MakeAbsoluteFilePath(const FilePath& input) {
   ThreadRestrictions::AssertIOAllowed();
   char full_path[PATH_MAX];
   if (realpath(input.value().c_str(), full_path) == NULL)
     return FilePath();
   return FilePath(full_path);
 }
@@ skipping 505 matching lines @@
 #if defined(OS_ANDROID)
   }
 #endif  // defined(OS_ANDROID)
 
   results->FromStat(file_info);
   return true;
 }
 #endif  // !defined(OS_NACL_NONSFI)
 
 FILE* OpenFile(const FilePath& filename, const char* mode) {
+  // 'e' is unconditionally added below, so be sure there is not one already
+  // present before a comma in |mode|.
+  DCHECK(::strchr(mode, 'e') == nullptr ||

[Mark Mentovai, 2017/02/09 15:15:16]

No ::

[grt (UTC plus 2), 2017/02/10 09:37:21]

Done.

+         (::strchr(mode, ',') != nullptr &&
+          ::strchr(mode, 'e') > ::strchr(mode, ',')));
   ThreadRestrictions::AssertIOAllowed();
   FILE* result = NULL;
+  std::string mode_with_e(AppendModeCharacter(mode, 'e'));
   do {
-    result = fopen(filename.value().c_str(), mode);
+    result = fopen(filename.value().c_str(), mode_with_e.c_str());
   } while (!result && errno == EINTR);
+#if defined(OS_MACOSX)
+  // Mark the descriptor as close-on-exec.
+  if (result)
+    SetCloseOnExec(fileno(result));
+#endif
   return result;
 }
 
 // NaCl doesn't implement system calls to open files directly.
 #if !defined(OS_NACL)
 FILE* FileToFILE(File file, const char* mode) {
   FILE* stream = fdopen(file.GetPlatformFile(), mode);
   if (stream)
     file.TakePlatformFile();
   return stream;
@@ skipping 254 matching lines @@
     return false;
 
   DeleteFile(from_path, true);
   return true;
 }
 
 }  // namespace internal
 
 #endif  // !defined(OS_NACL_NONSFI)
 }  // namespace base