Linux/Windows: Setting focus to the first profile in profile switcher

chrome/browser/ui/browser_commands.cc

Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index dd93505cd82f822fd6c504f05916dc51bee71aa6..37b977b42ce8886ab5964922eec35c1e5562dd3a 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -1125,14 +1125,14 @@ void ShowAppMenu(Browser* browser) {
 void ShowAvatarMenu(Browser* browser) {
   browser->window()->ShowAvatarBubbleFromAvatarButton(
       BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT, signin::ManageAccountsParams(),
-      signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);
+      signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN, true);
 }
 
 void ShowFastUserSwitcher(Browser* browser) {

[sky, 2017/02/09 20:17:39]

Is this called anywhere?

[jlebel, 2017/02/10 12:13:43]

@anthonyvd Do you think this is still used?

Should I remove this code in a next patch if it is not used anymore?

[anthonyvd, 2017/02/13 15:46:45]

It's potentially called in one place, although it shouldn't be since we removed
the fast user switcher. I think it's still in the code because there was a
transition period where we wanted to show the full avatar menu when people tried
to use the fast user switcher.

You should ask ewald@ if it's now fine to remove the right-clickability of the
avatar button. If it is, you can safely remove this function and clean up
IDC_SHOW_FAST_USER_SWITCHER and whatever's around it.

[jlebel, 2017/02/20 16:11:23]

I talked offline with ewald@, this feature is not used anymore. I created:
crbug.com/694285

   browser->window()->ShowAvatarBubbleFromAvatarButton(
       BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH,
       signin::ManageAccountsParams(),
-      signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN);
+      signin_metrics::AccessPoint::ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN, false);
 }
 
 void OpenUpdateChromeDialog(Browser* browser) {