Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 2687643004: MD Settings: CrOS: Add secondary user banner (Closed)
Patch Set: Rebase + feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/basic_page/basic_page.html
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html
index 7f75d71b7d58e539d7d42e9eeaf640a40abc13d1..0b6aa24084daa6970c4db7f8f1c7f53eee88ce6c 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.html
+++ b/chrome/browser/resources/settings/basic_page/basic_page.html
@@ -49,6 +49,23 @@
padding: 0 12px;
}
+ #secondaryUserBanner {
+ @apply(--shadow-elevation-2dp);
+ background-color: white;
+ border-radius: 2px;
+ margin: 21px 0;
+ }
+
+ #secondaryUserIcon {
+ background-color: rgb(210, 210, 212);
dschuyler 2017/02/13 21:45:59 Is there an MD color we can use here (maybe grey 2
dschuyler 2017/02/13 22:18:47 To give more options, any of these would be ok wit
stevenjb 2017/02/13 22:59:24 TODO added. I wanted to avoid an arbitrary change
+ background-image: url(chrome://theme/IDR_SECONDARY_USER_SETTINGS);
+ background-position: center;
+ background-repeat: no-repeat;
+ height: 55px;
+ margin: 18px;
+ width: 58px;
+ }
+
#toggleContainer {
align-items: center;
display: flex;
@@ -74,6 +91,13 @@
</settings-reset-profile-banner>
</template>
<if expr="chromeos">
+ <div id="secondaryUserBanner" class="layout horizontal center"
+ hidden="[[!showSecondaryUserBanner_]]">
+ <div id="secondaryUserIcon"></div>
+ <div class="flex">$i18n{secondaryUserBannerText}</div>
+ </div>
+</if>
+<if expr="chromeos">
dschuyler 2017/02/13 21:51:50 Can lines 99 and 100 be deleted?
stevenjb 2017/02/13 21:58:27 In theory, yes, in practice, the blocks are unrela
<template is="dom-if" if="[[showPage(pageVisibility.internet)]]"
restamp>
<settings-section page-title="$i18n{internetPageTitle}"
« no previous file with comments | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698