MD Settings: CrOS: Add secondary user banner

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/i18n/number_formatting.h"
@@ skipping 979 matching lines @@
 }
 
 #if defined(OS_CHROMEOS)
 void AddMultiProfilesStrings(content::WebUIDataSource* html_source,
                              Profile* profile) {
   user_manager::UserManager* user_manager = user_manager::UserManager::Get();
 
   const user_manager::User* user =
       chromeos::ProfileHelper::Get()->GetUserByProfile(profile);
   const user_manager::User* primary_user = user_manager->GetPrimaryUser();
-  html_source->AddString("primaryUserEmail",
-                         primary_user->GetAccountId().GetUserEmail());
+  std::string primary_user_email = primary_user->GetAccountId().GetUserEmail();
+  html_source->AddString("primaryUserEmail", primary_user_email);
   html_source->AddBoolean(
       "isSecondaryUser",
       user && user->GetAccountId() != primary_user->GetAccountId());
+  html_source->AddString(
+      "secondaryUserBannerText",
+      l10n_util::GetStringFUTF16(IDS_SETTINGS_SECONDARY_USER_BANNER,
+                                 base::ASCIIToUTF16(primary_user_email)));

[dschuyler, 2017/02/11 02:54:56]

I believe this will be converted back to UTF8 again. Is it reasonable to keep
this in utf8 rather than converting back and forth?

[stevenjb, 2017/02/13 18:28:00]

It's not UTF8, this is all UTF16.

[dschuyler, 2017/02/13 21:37:09]

Maybe I'm missing something(?). It looks like primary_user_email is converted
from ascii(utf8) to utf16 here on line 1008; then it's passed so AddString which
internally converts back from utf16 to utf8 on line 119 in
web_ui_data_source_impl.cc. (The secondary path on line 118 in
web_ui_data_source_impl.cc converts from utf16 to utf8 on line 160 within
values.cc).

I accept that converting strings is fairly fast, but doing it here and elsewhere
can add up -- it's a trend I'm trying to turn the other way (into doing fewer
conversions). It's not easy to see how many conversions are happening, so I'm
trying to highlight that (or if I'm wrong, I'd like to find out where and how).

[stevenjb, 2017/02/13 21:58:27]

While you are not wrong, that seems like something we should address in general
and not in this CL? Or do you have a specific suggestion here that would be
better that I am missing? Combining the strings in C++ is almost certainly going
to be faster than doing so in JS, conversion or no.

 }
 #endif
 
 void AddOnStartupStrings(content::WebUIDataSource* html_source) {
   LocalizedString localized_strings[] = {
       {"onStartup", IDS_SETTINGS_ON_STARTUP},
       {"onStartupOpenNewTab", IDS_SETTINGS_ON_STARTUP_OPEN_NEW_TAB},
       {"onStartupContinue", IDS_SETTINGS_ON_STARTUP_CONTINUE},
       {"onStartupOpenSpecific", IDS_SETTINGS_ON_STARTUP_OPEN_SPECIFIC},
       {"onStartupUseCurrent", IDS_SETTINGS_ON_STARTUP_USE_CURRENT},
@@ skipping 893 matching lines @@
 
 #if defined(OS_CHROMEOS)
   chromeos::network_element::AddLocalizedStrings(html_source);
 #endif
   policy_indicator::AddLocalizedStrings(html_source);
 
   html_source->SetJsonPath(kLocalizedStringsFile);
 }
 
 }  // namespace settings