Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2687593002: PlzNavigate: Invoke didFailProvisionalLoad() in the renderer when a navigation request is cancelled… (Closed)
Patch Set: Address review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index f773065636dfe57d0ae6fe63423fc7970a3b896d..f87be78eb35f2333e12358d3424fe7d03e74233f 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -1231,6 +1231,11 @@ void FrameLoader::stopAllLoaders() {
m_inStopAllLoaders = true;
+ if (m_isNavigationHandledByClient && client()) {
Nate Chapin 2017/02/09 00:10:07 I'm ~99% confident client() should be guaranteed n
ananta 2017/02/09 00:22:46 Thanks. Removed the null check
+ client()->dispatchDidFailProvisionalLoad(
+ ResourceError::cancelledError(String()), StandardCommit);
+ }
+
m_isNavigationHandledByClient = false;
for (Frame* child = m_frame->tree().firstChild(); child;
« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698