Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: components/metrics/BUILD.gn

Issue 2687583002: Add support for single sample metrics. (Closed)
Patch Set: Fix ios hopefully; address comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/BUILD.gn
diff --git a/components/metrics/BUILD.gn b/components/metrics/BUILD.gn
index 3852c12e5dd9d5588dd087ef3e51c2e51fa98373..32330c8ecd5609e3147070a4fddd52f9957a560b 100644
--- a/components/metrics/BUILD.gn
+++ b/components/metrics/BUILD.gn
@@ -91,8 +91,11 @@ static_library("metrics") {
]
public_deps = [
+ ":single_sample_metrics",
"//components/metrics/proto",
+ "//components/metrics/public/interfaces:single_sample_metrics_mojo_bindings",
]
+
deps = [
":call_stack_profile_params",
"//base",
@@ -248,6 +251,20 @@ if (!is_ios) {
}
}
+source_set("single_sample_metrics") {
+ sources = [
+ "single_sample_metrics_factory_impl.cc",
+ "single_sample_metrics_factory_impl.h",
+ "single_sample_metrics_provider.cc",
Alexei Svitkine (slow) 2017/05/03 21:18:47 Hmm, I find this naming unfortunate - because we a
DaleCurtis 2017/05/03 21:37:51 This is naming convention used by mojo for these t
Alexei Svitkine (slow) 2017/05/03 21:45:08 Perhaps we can put something between "metrics" and
DaleCurtis 2017/05/04 02:28:59 Okay, I think I have a compromise which works. I'v
DaleCurtis 2017/05/04 03:09:24 Ah, actually this doesn't work since AddInterface(
DaleCurtis 2017/05/04 18:55:27 Oooh, fixed my template errors so this is working
+ "single_sample_metrics_provider.h",
+ ]
+
+ deps = [
+ "//components/metrics/public/interfaces:single_sample_metrics_mojo_bindings",
+ "//mojo/public/cpp/bindings",
+ ]
+}
+
source_set("call_stack_profile_params") {
sources = [
"call_stack_profile_params.cc",
@@ -335,6 +352,8 @@ source_set("unit_tests") {
"persisted_logs_unittest.cc",
"profiler/profiler_metrics_provider_unittest.cc",
"profiler/tracking_synchronizer_unittest.cc",
+ "single_sample_metrics_factory_impl_unittest.cc",
+ "single_sample_metrics_provider_unittest.cc",
"stability_metrics_helper_unittest.cc",
"stability_metrics_provider_unittest.cc",
"ui/screen_info_metrics_provider_unittest.cc",

Powered by Google App Engine
This is Rietveld 408576698