Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Side by Side Diff: media/renderers/video_renderer_impl.cc

Issue 2687583002: Add support for single sample metrics. (Closed)
Patch Set: Use thread local storage. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/renderers/video_renderer_impl.h" 5 #include "media/renderers/video_renderer_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/callback_helpers.h" 11 #include "base/callback_helpers.h"
12 #include "base/location.h" 12 #include "base/location.h"
13 #include "base/metrics/histogram_macros.h" 13 #include "base/metrics/histogram_macros.h"
14 #include "base/metrics/single_value_histograms.h"
14 #include "base/single_thread_task_runner.h" 15 #include "base/single_thread_task_runner.h"
15 #include "base/strings/string_util.h" 16 #include "base/strings/string_util.h"
16 #include "base/time/default_tick_clock.h" 17 #include "base/time/default_tick_clock.h"
17 #include "base/trace_event/trace_event.h" 18 #include "base/trace_event/trace_event.h"
18 #include "media/base/bind_to_current_loop.h" 19 #include "media/base/bind_to_current_loop.h"
19 #include "media/base/limits.h" 20 #include "media/base/limits.h"
20 #include "media/base/media_log.h" 21 #include "media/base/media_log.h"
21 #include "media/base/media_switches.h" 22 #include "media/base/media_switches.h"
22 #include "media/base/pipeline_status.h" 23 #include "media/base/pipeline_status.h"
23 #include "media/base/renderer_client.h" 24 #include "media/base/renderer_client.h"
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 DCHECK(task_runner_->BelongsToCurrentThread()); 144 DCHECK(task_runner_->BelongsToCurrentThread());
144 base::AutoLock auto_lock(lock_); 145 base::AutoLock auto_lock(lock_);
145 DCHECK(stream); 146 DCHECK(stream);
146 DCHECK_EQ(stream->type(), DemuxerStream::VIDEO); 147 DCHECK_EQ(stream->type(), DemuxerStream::VIDEO);
147 DCHECK(!init_cb.is_null()); 148 DCHECK(!init_cb.is_null());
148 DCHECK(!wall_clock_time_cb.is_null()); 149 DCHECK(!wall_clock_time_cb.is_null());
149 DCHECK(kUninitialized == state_ || kFlushed == state_); 150 DCHECK(kUninitialized == state_ || kFlushed == state_);
150 DCHECK(!was_background_rendering_); 151 DCHECK(!was_background_rendering_);
151 DCHECK(!time_progressing_); 152 DCHECK(!time_progressing_);
152 153
154 std::unique_ptr<base::SingleValueCountsHistogram> metric_1(
155 base::SingleValueHistogramsFactory::Get()
156 ->CreateSingleValueCountsHistogram(
157 "Media.VideoRenderer.CadenceChanges", 1, 10, 10));
158 metric_1->SetSample(7);
159 metric_1->SetSample(9);
160
153 ScopedVector<VideoDecoder> decoders = create_video_decoders_cb_.Run(); 161 ScopedVector<VideoDecoder> decoders = create_video_decoders_cb_.Run();
154 video_frame_stream_.reset( 162 video_frame_stream_.reset(
155 new VideoFrameStream(task_runner_, std::move(decoders), media_log_)); 163 new VideoFrameStream(task_runner_, std::move(decoders), media_log_));
156 164
157 // Always re-initialize or reset the |gpu_memory_buffer_pool_| in case we are 165 // Always re-initialize or reset the |gpu_memory_buffer_pool_| in case we are
158 // switching between video tracks with incompatible video formats (e.g. 8-bit 166 // switching between video tracks with incompatible video formats (e.g. 8-bit
159 // H.264 to 10-bit H264 or vice versa). 167 // H.264 to 10-bit H264 or vice versa).
160 if (gpu_factories_ && 168 if (gpu_factories_ &&
161 gpu_factories_->ShouldUseGpuMemoryBuffersForVideoFrames()) { 169 gpu_factories_->ShouldUseGpuMemoryBuffersForVideoFrames()) {
162 gpu_memory_buffer_pool_.reset(new GpuMemoryBufferVideoFramePool( 170 gpu_memory_buffer_pool_.reset(new GpuMemoryBufferVideoFramePool(
(...skipping 572 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 743
736 void VideoRendererImpl::AttemptReadAndCheckForMetadataChanges( 744 void VideoRendererImpl::AttemptReadAndCheckForMetadataChanges(
737 VideoPixelFormat pixel_format, 745 VideoPixelFormat pixel_format,
738 const gfx::Size& natural_size) { 746 const gfx::Size& natural_size) {
739 base::AutoLock auto_lock(lock_); 747 base::AutoLock auto_lock(lock_);
740 CheckForMetadataChanges(pixel_format, natural_size); 748 CheckForMetadataChanges(pixel_format, natural_size);
741 AttemptRead_Locked(); 749 AttemptRead_Locked();
742 } 750 }
743 751
744 } // namespace media 752 } // namespace media
OLDNEW
« components/metrics/DEPS ('K') | « media/filters/video_cadence_estimator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698