components/metrics/DEPS - Issue 2687583002: Add support for single sample metrics.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/metrics/DEPS

Issue 2687583002: Add support for single sample metrics. (Closed)

Patch Set: Use thread local storage. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # This component is shared with the Chrome OS build, so it's important to limit	1 # This component is shared with the Chrome OS build, so it's important to limit

2 # dependencies to a minimal set.	2 # dependencies to a minimal set.

3 include_rules = [	3 include_rules = [

4 "-components",	4 "-components",

5 "+components/browser_watcher",	5 "+components/browser_watcher",

6 "+components/compression",	6 "+components/compression",

7 "+components/metrics",	7 "+components/metrics",

8 "+components/prefs",	8 "+components/prefs",

9 "+components/variations",	9 "+components/variations",

10 "+components/version_info",	10 "+components/version_info",

	11 "+content/public/common",
	Alexei Svitkine (slow) 2017/04/26 18:12:53 We don't want metrics component to depend on conte We don't want metrics component to depend on content. In particular, because it may be used by things that don't depend on content themselves, like iOS Chrome. The convention we use inside components/metrics is to have a sub-directory for things that have more dependencies - e.g. components/metrics/net has code that has dependencies on net/. So it would make sense to add the new stuff under components/metrics/content if it depends on content. DaleCurtis 2017/04/29 00:30:35 Done. Now the service name is passed in as a std:: Show quoted text On 2017/04/26 at 18:12:53, Alexei Svitkine (slow) wrote: > We don't want metrics component to depend on content. In particular, because it may be used by things that don't depend on content themselves, like iOS Chrome. > > The convention we use inside components/metrics is to have a sub-directory for things that have more dependencies - e.g. components/metrics/net has code that has dependencies on net/. So it would make sense to add the new stuff under components/metrics/content if it depends on content. Done. Now the service name is passed in as a std::string, so no DEP necessary.
11 "+content/public/test",	12 "+content/public/test",

12 "+mojo/public/cpp",	13 "+mojo/public/cpp",

13 "+services/service_manager/public/cpp",	14 "+services/service_manager/public/cpp",

14 "+third_party/zlib/google",	15 "+third_party/zlib/google",

15 "-net",	16 "-net",

16 ]	17 ]

OLD	NEW

« base/metrics/single_value_histograms.cc ('K') | « components/metrics/BUILD.gn ('k') | components/metrics/public/interfaces/BUILD.gn » ('j') | no next file with comments »