Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2050)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Issue 2687573002: [Android Webview] Refactor LoadUrlTest and work on embedded_test_server custom handler (Closed)
Patch Set: discussing patch Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
index a475c499130b3ed70121054614f60c594a0ec456..d73f5e7466b66898690fcfed7e9a1b64c62690d1 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
@@ -451,9 +451,7 @@ public class AwContentsTest extends AwTestBase {
extraHeaders.put("X-foo", "bar");
loadUrlSync(awContents, mContentsClient.getOnPageFinishedHelper(), url, extraHeaders);
- String xfoo = maybeStripDoubleQuotes(JSUtils.executeJavaScriptAndWaitForResult(this,
- awContents, mContentsClient.getOnEvaluateJavaScriptResultHelper(),
- "document.body.textContent"));
+ String xfoo = getJavaScriptResultBodyTextContent(awContents, mContentsClient);
assertEquals("bar", xfoo);
url = testServer.getURL("/echoheader?Referer");
@@ -462,9 +460,7 @@ public class AwContentsTest extends AwTestBase {
extraHeaders.put("Referer", "http://www.example.com/");
loadUrlSync(awContents, mContentsClient.getOnPageFinishedHelper(), url, extraHeaders);
- String referer = maybeStripDoubleQuotes(JSUtils.executeJavaScriptAndWaitForResult(this,
- awContents, mContentsClient.getOnEvaluateJavaScriptResultHelper(),
- "document.body.textContent"));
+ String referer = getJavaScriptResultBodyTextContent(awContents, mContentsClient);
assertEquals("http://www.example.com/", referer);
} finally {
testServer.stopAndDestroyServer();

Powered by Google App Engine
This is Rietveld 408576698