android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java - Issue 2687573002: [Android Webview] Refactor LoadUrlTest and work on embedded_test_server custom handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 2687573002: [Android Webview] Refactor LoadUrlTest and work on embedded_test_server custom handler (Closed)

Patch Set: sgurun comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java » ('j') | android_webview/test/embedded_test_server/aw_embedded_test_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

index a262b338fe943f4ce4cc3c2bc6d0c92b2d1eeac2..c075f056112bbd1c5f98f5082aef1b7efb3b7db1 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

@@ -1772,9 +1772,7 @@ public class AwSettingsTest extends AwTestBase {

loadUrlSync(awContents,

contentClient.getOnPageFinishedHelper(),

url);

- String userAgent = maybeStripDoubleQuotes(JSUtils.executeJavaScriptAndWaitForResult(

- this, awContents, contentClient.getOnEvaluateJavaScriptResultHelper(),

- "document.body.textContent"));

+ String userAgent = getJavaScriptResultBodyTextContent(awContents, contentClient);

assertEquals(customUserAgentString, userAgent);

} finally {

testServer.stopAndDestroyServer();