Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: android_webview/embeddedtestserver/java/src/org/chromium/net/test/AwEmbeddedTestServerImpl.java

Issue 2687573002: [Android Webview] Refactor LoadUrlTest and work on embedded_test_server custom handler (Closed)
Patch Set: ready Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/embeddedtestserver/java/src/org/chromium/net/test/AwEmbeddedTestServerImpl.java
diff --git a/android_webview/embeddedtestserver/java/src/org/chromium/net/test/AwEmbeddedTestServerImpl.java b/android_webview/embeddedtestserver/java/src/org/chromium/net/test/AwEmbeddedTestServerImpl.java
new file mode 100644
index 0000000000000000000000000000000000000000..abfb75162a2c1e1efce10e5fd5c7cb35d7618f64
--- /dev/null
+++ b/android_webview/embeddedtestserver/java/src/org/chromium/net/test/AwEmbeddedTestServerImpl.java
@@ -0,0 +1,42 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
jbudorick 2017/03/09 02:00:47 nit: This shouldn't be android_webview/embeddedtes
shenghuazhang 2017/03/13 18:48:15 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.net.test;
+
+import android.content.Context;
+
+import java.util.concurrent.Callable;
+
+/**
+ * Java bindings for running a net::test_server::EmbeddedTestServer.
+ *
+ * This should not be used directly. Use {@link EmbeddedTestServer} instead.
+ */
+public class AwEmbeddedTestServerImpl extends EmbeddedTestServerImpl {
+ /** Create an uninitialized EmbeddedTestServer. */
+ public AwEmbeddedTestServerImpl(Context context) {
jbudorick 2017/03/09 02:00:47 I think this can be omitted.
shenghuazhang 2017/03/13 18:48:15 Hmm...Actually it would reveal constructor error w
+ super(context);
+ }
+ /** Add the default handlers and serve files from the provided directory relative to the
+ * external storage directory.
+ *
+ * @param directoryPath The path of the directory from which files should be served, relative
+ * to the external storage directory.
+ */
+ @Override
+ public void addDefaultHandlers(final String directoryPath) {
+ runOnHandlerThread(new Callable<Void>() {
+ @Override
+ public Void call() {
+ nativeAddDefaultHandlers(mNativeEmbeddedTestServer, directoryPath);
+ CustomHandlers custom_handlers = new CustomHandlers();
+ long[] handlers = custom_handlers.getHandlers();
+ for (long h : handlers) {
+ nativeRegisterRequestHandler(mNativeEmbeddedTestServer, h);
+ }
+ return null;
+ }
+ });
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698