chrome/browser/resources/settings/site_settings/site_data_details_subpage.js - Issue 2687553003: MD Settings: Fix site data details regression and add test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_subpage.js

Issue 2687553003: MD Settings: Fix site data details regression and add test. (Closed)

Patch Set: resetRoutForTesting() Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/cookie_info.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_data_details_subpage.js

diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js b/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js

index d7ea49bb4b94fec3d3c5de53d9b100230238b22f..7196b784d4898740f2124c47f748fafb1c79ef69 100644

--- a/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js

+++ b/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js

@@ -22,7 +22,7 @@ Polymer({

/**

* The cookie entries for the given site.

- * @type {!Array<!CookieDataItem>}

+ * @type {!Array<!CookieDetails>}

* @private

entries_: Array,

@@ -83,14 +83,14 @@ Polymer({

/**

- * @param {!CookieDataSummaryItem} cookies

+ * @param {!CookieList} cookies

* @private

onCookiesLoaded_: function(cookies) {

this.siteId_ = cookies.id;

this.entries_ = cookies.children;

// Set up flag for expanding cookie details.

- this.entries_.map(function(e) { return e.expanded_ = false; });

+ this.entries_.forEach(function(e) { e.expanded_ = false; });

/**