Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10777)

Unified Diff: chrome/test/data/webui/settings/site_list_tests.js

Issue 2687553003: MD Settings: Fix site data details regression and add test. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/site_list_tests.js
diff --git a/chrome/test/data/webui/settings/site_list_tests.js b/chrome/test/data/webui/settings/site_list_tests.js
index 7b13e5c464720977960abf966dfde55567446f18..3ccf52f6a4731d5c2498ca6131521ff68649af8a 100644
--- a/chrome/test/data/webui/settings/site_list_tests.js
+++ b/chrome/test/data/webui/settings/site_list_tests.js
@@ -344,6 +344,9 @@ cr.define('site_list', function() {
teardown(function() {
closeActionMenu();
+ // The code being tested changes the URL. Reset so that URL state is not
+ // leaked across tests.
+ settings.navigateTo(settings.Route.BASIC);
tommycli 2017/02/08 22:04:17 well technically it's the internal route variable
dpapad 2017/02/08 22:16:42 I see. In that case, how about calling resetRouteF
});
/**

Powered by Google App Engine
This is Rietveld 408576698