MD Settings: Fix site data details regression and add test.

chrome/test/data/webui/settings/site_list_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-list. */
 cr.define('site_list', function() {
   function registerTests() {
     suite('SiteList', function() {
       /**
        * A site list element created before each test.
@@ skipping 326 matching lines @@
       setup(function() {
         browserProxy = new TestSiteSettingsPrefsBrowserProxy();
         settings.SiteSettingsPrefsBrowserProxyImpl.instance_ = browserProxy;
         PolymerTest.clearBody();
         testElement = document.createElement('site-list');
         document.body.appendChild(testElement);
       });
 
       teardown(function() {
         closeActionMenu();
+        // The code being tested changes the URL. Reset so that URL state is not
+        // leaked across tests.
+        settings.navigateTo(settings.Route.BASIC);

[tommycli, 2017/02/08 22:04:17]

well technically it's the internal route variable that matters, not the actual
URL...

[dpapad, 2017/02/08 22:16:42]

I see. In that case, how about calling resetRouteForTesting() instead (see new
patch)? (I had added that method in a previous CL, necessary for when tests run
in vulcanized mode).

       });
 
       /**
        * Fetch the non-hidden menu items from the action menu.
        */
       function getMenuItems() {
         var menu = testElement.$$('dialog[is=cr-action-menu]');
         assertTrue(!!menu);
         return menu.querySelectorAll('button:not([hidden])');
       }
@@ skipping 526 matching lines @@
           assertEquals(settings.ContentSettingsTypes.JAVASCRIPT, args[2]);
           assertEquals('allow', args[3]);
         });
       });
     });
   }
   return {
     registerTests: registerTests,
   };
 });