Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2687533003: Replace bad_raw_string_negative_test with a multitest (Closed)

Created:
3 years, 10 months ago by Bill Hesse
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, Brian Wilkerson, eernst
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace bad_raw_string_negative_test with a multitest BUG=https://github.com/dart-lang/sdk/issues/28664 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/25e97c608255d5781ea5b4e731fc32c2d9d987b1

Patch Set 1 #

Patch Set 2 : fix long line #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
D tests/language/bad_raw_string_negative_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download
A tests/language/bad_raw_string_test.dart View 1 1 chunk +23 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
3 years, 10 months ago (2017-02-07 21:48:06 UTC) #2
Bill Hesse
3 years, 10 months ago (2017-02-07 21:54:01 UTC) #4
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-07 22:47:36 UTC) #5
Bill Hesse
3 years, 10 months ago (2017-02-07 22:55:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
25e97c608255d5781ea5b4e731fc32c2d9d987b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698