content/browser/service_worker/embedded_worker_instance.cc - Issue 268753004: Add WorkerScriptLoaded message to support attaching DevTools while starting ServiceWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 268753004: Add WorkerScriptLoaded message to support attaching DevTools while starting ServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated nasko's comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/embedded_worker_instance.h ('k') | content/browser/service_worker/embedded_worker_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/embedded_worker_instance.cc

diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc

index b56df25d360c32cb54c4346671cde192937df6b0..24d2a9529a9843eb6dbf7c36e44efeabd748dd4d 100644

--- a/content/browser/service_worker/embedded_worker_instance.cc

+++ b/content/browser/service_worker/embedded_worker_instance.cc

@@ -99,6 +99,13 @@ void EmbeddedWorkerInstance::RecordProcessId(

}

+void EmbeddedWorkerInstance::OnScriptLoaded() {

+ // TODO(horo): Implement this.

+void EmbeddedWorkerInstance::OnScriptLoadFailed() {

void EmbeddedWorkerInstance::OnStarted(int thread_id) {

// Stop is requested before OnStarted is sent back from the worker.

if (status_ == STOPPING)