Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2687433003: Gardening: Adjusted status of packages_option_only_test. (Closed)

Created:
3 years, 10 months ago by eernst
Modified:
3 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gardening: Adjusted status of packages_option_only_test. In 13 out of 20 builds ending in 2620 on analyzer-win7-release-be this test has outcome CompileTimeError rather than Crash. This CL adds that outcome to the status file, for windows platforms. Committed: https://github.com/dart-lang/sdk/commit/29b1dbe56f22239aa9e743f5af1cd067b4ae944e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/standalone/standalone.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
TBR: Gardening, status adjustment to match actual behavior. Brian has been notified of the change ...
3 years, 10 months ago (2017-02-07 15:32:08 UTC) #2
eernst
Committed patchset #1 (id:1) manually as 29b1dbe56f22239aa9e743f5af1cd067b4ae944e (presubmit successful).
3 years, 10 months ago (2017-02-07 15:32:53 UTC) #4
floitsch
3 years, 10 months ago (2017-02-07 15:38:36 UTC) #5
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698