[XHR] Delete an incorrect ASSERT

[XHR] Delete an incorrect ASSERT

Resource::revalidationSucceeded ASSERTs that the resource exists in the
memory cache. But the assumption is not correct because an ongoing revalidation
request can be evicted by the reloading request for the same URL.
Because no one relies on the assumption, the assert can be deleted.

BUG=370792
R=japhet@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173711

[yhirano, 2014-05-02 09:57:49]

The assumption was once correct, but
https://src.chromium.org/viewvc/blink?revision=171184&view=revision violated it.
I think the assumption can be deleted safely.

[Nate Chapin, 2014-05-02 16:33:20]

On 2014/05/02 09:57:49, yhirano (OOO until May 6) wrote:
> The assumption was once correct, but
> https://src.chromium.org/viewvc/blink?revision=171184&view=revision violated
it.
> I think the assumption can be deleted safely.

I don't think 171184 could actually modify our ability to hit that ASSERT. If
you have a webpage that reliably hits that ASSERT, it would be useful to study
it and understand how it is happening. There is a (small?) chance that this case
could cause subtle memory lifetime issues.

[yhirano, 2014-05-07 08:22:58]

On 2014/05/02 16:33:20, Nate Chapin wrote:
> On 2014/05/02 09:57:49, yhirano (OOO until May 6) wrote:
> > The assumption was once correct, but
> > https://src.chromium.org/viewvc/blink?revision=171184&view=revision violated
> it.
> > I think the assumption can be deleted safely.
> 
> I don't think 171184 could actually modify our ability to hit that ASSERT. If
> you have a webpage that reliably hits that ASSERT, it would be useful to study
> it and understand how it is happening. There is a (small?) chance that this
case
> could cause subtle memory lifetime issues.

Let's discuss at http://crbug.com/370792 .

[Nate Chapin, 2014-05-08 18:07:38]

Thanks! LGTM

[yhirano, 2014-05-08 23:12:55]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-05-08 23:14:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yhirano@chromium.org/268743003/20001

[commit-bot: I haz the power, 2014-05-09 00:30:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6254)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/6722)

[commit-bot: I haz the power, 2014-05-09 01:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-09 01:04:20]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6262)

[yhirano, 2014-05-09 02:01:01]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-05-09 02:02:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yhirano@chromium.org/268743003/20001

[commit-bot: I haz the power, 2014-05-09 02:44:09]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/6740)

[commit-bot: I haz the power, 2014-05-09 03:44:17]

Change committed as 173711