Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 268743002: Compress uploaded android logs (Closed)

Created:
6 years, 7 months ago by Isaac (away)
Modified:
6 years, 7 months ago
Reviewers:
navabi1, iannucci, luqui
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Compress uploaded android logs gzip files so clients can download faster. BUG=362787 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267983

Patch Set 1 #

Patch Set 2 : bug fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 12 (0 generated)
Isaac (away)
6 years, 7 months ago (2014-05-02 05:05:58 UTC) #1
luqui
lgtm (I'm no owner though)
6 years, 7 months ago (2014-05-02 18:21:42 UTC) #2
Isaac (away)
The CQ bit was checked by ilevy@chromium.org
6 years, 7 months ago (2014-05-02 18:53:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/268743002/20001
6 years, 7 months ago (2014-05-02 18:53:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 18:53:42 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-02 18:53:42 UTC) #6
iannucci
https://codereview.chromium.org/268743002/diff/20001/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/268743002/diff/20001/build/android/buildbot/bb_device_steps.py#newcode576 build/android/buildbot/bb_device_steps.py:576: RunCmd([bb_utils.GSUTIL_PATH, 'cp', '-z', 'txt', logcat_file, isn't gsutil content type ...
6 years, 7 months ago (2014-05-02 18:56:53 UTC) #7
Isaac (away)
https://codereview.chromium.org/268743002/diff/20001/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/268743002/diff/20001/build/android/buildbot/bb_device_steps.py#newcode576 build/android/buildbot/bb_device_steps.py:576: RunCmd([bb_utils.GSUTIL_PATH, 'cp', '-z', 'txt', logcat_file, On 2014/05/02 18:56:53, iannucci ...
6 years, 7 months ago (2014-05-02 18:59:16 UTC) #8
iannucci
okie smokes, lgtm :)
6 years, 7 months ago (2014-05-02 19:12:52 UTC) #9
Isaac (away)
The CQ bit was checked by ilevy@chromium.org
6 years, 7 months ago (2014-05-02 19:16:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/268743002/20001
6 years, 7 months ago (2014-05-02 19:16:53 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 00:07:32 UTC) #12
Message was sent while issue was closed.
Change committed as 267983

Powered by Google App Engine
This is Rietveld 408576698