Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Unified Diff: components/metrics/metrics_log.h

Issue 2687393004: Gather stability prefs into managing objects. (Closed)
Patch Set: Remove unused method Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_log.h
diff --git a/components/metrics/metrics_log.h b/components/metrics/metrics_log.h
index fb4bef2b9d7dcafe61dce481adb60c6f58c1b9e5..27b07a68a0dca9c66349d6c6499ba6fc378247da 100644
--- a/components/metrics/metrics_log.h
+++ b/components/metrics/metrics_log.h
@@ -18,7 +18,6 @@
#include "components/metrics/metrics_service_client.h"
#include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
-class PrefRegistrySimple;
class PrefService;
namespace base {
@@ -56,9 +55,6 @@ class MetricsLog {
PrefService* local_state);
virtual ~MetricsLog();
- // Registers local state prefs used by this class.
- static void RegisterPrefs(PrefRegistrySimple* registry);
-
// Computes the MD5 hash of the given string, and returns the first 8 bytes of
// the hash.
static uint64_t Hash(const std::string& value);
@@ -172,15 +168,11 @@ class MetricsLog {
// call to RecordStabilityMetrics().
bool HasStabilityMetrics() const;
- // Within the stability group, write required attributes.
- void WriteRequiredStabilityAttributes(PrefService* pref);
-
// Within the stability group, write attributes that need to be updated asap
// and can't be delayed until the user decides to restart chromium.
// Delaying these stats would bias metrics away from happy long lived
// chromium processes (ones that don't crash, and keep on running).
- void WriteRealtimeStabilityAttributes(PrefService* pref,
- base::TimeDelta incremental_uptime,
+ void WriteRealtimeStabilityAttributes(base::TimeDelta incremental_uptime,
base::TimeDelta uptime);
// closed_ is true when record has been packed up for sending, and should

Powered by Google App Engine
This is Rietveld 408576698