Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: components/metrics/metrics_log.h

Issue 2687393004: Gather stability prefs into managing objects. (Closed)
Patch Set: Incorporate Feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/metrics/environment_recorder_unittest.cc ('k') | components/metrics/metrics_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log.h
diff --git a/components/metrics/metrics_log.h b/components/metrics/metrics_log.h
index 5a01964a05d9ae68bc5a314ff3cf9fc390643605..4f28b43b3aea02211acebfaa0faad61d615a088e 100644
--- a/components/metrics/metrics_log.h
+++ b/components/metrics/metrics_log.h
@@ -19,7 +19,6 @@
#include "components/metrics/metrics_service_client.h"
#include "components/metrics/proto/chrome_user_metrics_extension.pb.h"
-class PrefRegistrySimple;
class PrefService;
namespace base {
@@ -173,15 +172,11 @@ class MetricsLog {
// call to RecordStabilityMetrics().
bool HasStabilityMetrics() const;
- // Within the stability group, write required attributes.
- void WriteRequiredStabilityAttributes(PrefService* pref);
-
// Within the stability group, write attributes that need to be updated asap
// and can't be delayed until the user decides to restart chromium.
// Delaying these stats would bias metrics away from happy long lived
// chromium processes (ones that don't crash, and keep on running).
- void WriteRealtimeStabilityAttributes(PrefService* pref,
- base::TimeDelta incremental_uptime,
+ void WriteRealtimeStabilityAttributes(base::TimeDelta incremental_uptime,
base::TimeDelta uptime);
// closed_ is true when record has been packed up for sending, and should
« no previous file with comments | « components/metrics/environment_recorder_unittest.cc ('k') | components/metrics/metrics_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698