Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1900)

Unified Diff: components/metrics/stability_pref_names.cc

Issue 2687393004: Gather stability prefs into managing objects. (Closed)
Patch Set: Keep MetricsLog::RegisterPrefs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/stability_pref_names.cc
diff --git a/components/metrics/metrics_pref_names.cc b/components/metrics/stability_pref_names.cc
similarity index 56%
copy from components/metrics/metrics_pref_names.cc
copy to components/metrics/stability_pref_names.cc
index c5ad9c6abf561e8c49822a7e58283da8777dfe70..1bc582aa517de49419688d4a6a250292adc55493 100644
--- a/components/metrics/metrics_pref_names.cc
+++ b/components/metrics/stability_pref_names.cc
@@ -1,71 +1,12 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/metrics/metrics_pref_names.h"
+#include "components/metrics/stability_pref_names.h"
namespace metrics {
namespace prefs {
-// Set once, to the current epoch time, on the first run of chrome on this
-// machine. Attached to metrics reports forever thereafter.
-const char kInstallDate[] = "uninstall_metrics.installation_date2";
-
-// The metrics client GUID.
-// Note: The name client_id2 is a result of creating
-// new prefs to do a one-time reset of the previous values.
-const char kMetricsClientID[] = "user_experience_metrics.client_id2";
-
-// An enum value indicating the default value of the enable metrics reporting
-// checkbox shown during first-run. If it's opt-in, then the checkbox defaulted
-// to unchecked, if it's opt-out, then it defaulted to checked. This value is
-// only recorded during first-run, so older clients will not set it. The enum
-// used for the value is metrics::MetricsServiceClient::EnableMetricsDefault.
-const char kMetricsDefaultOptIn[] = "user_experience_metrics.default_opt_in";
-
-// Array of dictionaries that are each UMA logs that were supposed to be sent in
-// the first minute of a browser session. These logs include things like crash
-// count info, etc.
-const char kMetricsInitialLogs[] = "user_experience_metrics.initial_logs2";
-
-// The metrics entropy source.
-// Note: The name low_entropy_source2 is a result of creating
-// new prefs to do a one-time reset of the previous values.
-const char kMetricsLowEntropySource[] =
- "user_experience_metrics.low_entropy_source2";
-
-// A machine ID used to detect when underlying hardware changes. It is only
-// stored locally and never transmitted in metrics reports.
-const char kMetricsMachineId[] = "user_experience_metrics.machine_id";
-
-// Array of dictionaries that are each UMA logs that were not sent because the
-// browser terminated before these accumulated metrics could be sent. These
-// logs typically include histograms and memory reports, as well as ongoing
-// user activities.
-const char kMetricsOngoingLogs[] = "user_experience_metrics.ongoing_logs2";
-
-// Boolean that indicates a cloned install has been detected and the metrics
-// client id and low entropy source should be reset.
-const char kMetricsResetIds[] = "user_experience_metrics.reset_metrics_ids";
-
-// Boolean that specifies whether or not crash reporting and metrics reporting
-// are sent over the network for analysis.
-const char kMetricsReportingEnabled[] =
- "user_experience_metrics.reporting_enabled";
-
-// Date/time when the user opted in to UMA and generated the client id most
-// recently (local machine time, stored as a 64-bit time_t value).
-const char kMetricsReportingEnabledTimestamp[] =
- "user_experience_metrics.client_id_timestamp";
-
-// The metrics client session ID.
-const char kMetricsSessionID[] = "user_experience_metrics.session_id";
-
-// The prefix of the last-seen timestamp for persistent histogram files.
-// Values are named for the files themselves.
-const char kMetricsLastSeenPrefix[] =
- "user_experience_metrics.last_seen.";
-
// Number of times the browser has been able to register crash reporting.
const char kStabilityBreakpadRegistrationSuccess[] =
"user_experience_metrics.stability.breakpad_registration_ok";
@@ -128,19 +69,10 @@ const char kStabilityExtensionRendererLaunchCount[] =
const char kStabilityIncompleteSessionEndCount[] =
"user_experience_metrics.stability.incomplete_session_end_count";
-// Time when the app was last known to be running, in seconds since
-// the epoch.
-const char kStabilityLastTimestampSec[] =
- "user_experience_metrics.stability.last_timestamp_sec";
-
// Number of times the application was launched since last report.
const char kStabilityLaunchCount[] =
"user_experience_metrics.stability.launch_count";
-// Time when the app was last launched, in seconds since the epoch.
-const char kStabilityLaunchTimeSec[] =
- "user_experience_metrics.stability.launch_time_sec";
-
// Number of times a page load event occurred since the last report.
const char kStabilityPageLoadCount[] =
"user_experience_metrics.stability.page_load_count";
@@ -191,21 +123,5 @@ const char kStabilityStatsVersion[] =
const char kStabilityVersionMismatchCount[] =
"user_experience_metrics.stability.version_mismatch_count";
-// The keys below are strictly increasing counters over the lifetime of
-// a chrome installation. They are (optionally) sent up to the uninstall
-// survey in the event of uninstallation.
-const char kUninstallLaunchCount[] = "uninstall_metrics.launch_count";
-const char kUninstallMetricsPageLoadCount[] =
- "uninstall_metrics.page_load_count";
-const char kUninstallMetricsUptimeSec[] = "uninstall_metrics.uptime_sec";
-
-// Dictionary for measuring cellular data used by UMA service during last 7
-// days.
-const char kUmaCellDataUse[] = "user_experience_metrics.uma_cell_datause";
-
-// Dictionary for measuring cellular data used by user including chrome services
-// per day.
-const char kUserCellDataUse[] = "user_experience_metrics.user_call_datause";
-
} // namespace prefs
} // namespace metrics
« components/metrics/stability_metrics_provider.h ('K') | « components/metrics/stability_pref_names.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698