third_party/WebKit/Source/core/dom/Range.h - Issue 2687273002: Selection API: Mutating a Range object after adding it to Selection should update Selection attribu…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Range.h

Issue 2687273002: Selection API: Mutating a Range object after adding it to Selection should update Selection attribu… (Closed)

Patch Set: Handle diffrent root cases Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Range.h

diff --git a/third_party/WebKit/Source/core/dom/Range.h b/third_party/WebKit/Source/core/dom/Range.h

index 7332da61496f1d49a830be3713cb612db72ba3a2..18bc278cd43c69ba6a620c5c81d999227144720d 100644

--- a/third_party/WebKit/Source/core/dom/Range.h

+++ b/third_party/WebKit/Source/core/dom/Range.h

@@ -207,6 +207,8 @@ class CORE_EXPORT Range final : public GarbageCollected<Range>,

Node* clonedContainer,

Node* commonRoot,

ExceptionState&);

+ void updateSelectionIfAddedToSelection();

+ void removeFromSelectionIfInDifferentRoot(Document& oldDocument);

Member<Document> m_ownerDocument; // Cannot be null.

RangeBoundaryPoint m_start;