third_party/WebKit/LayoutTests/editing/selection/selection-update-range-after-addrange.html - Issue 2687273002: Selection API: Mutating a Range object after adding it to Selection should update Selection attribu…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/selection/selection-update-range-after-addrange.html

Issue 2687273002: Selection API: Mutating a Range object after adding it to Selection should update Selection attribu… (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <p>abcdef</p>

	5 <script>

	6 test(() => {

	7 let selection = getSelection();

	8 selection.removeAllRanges();

	9 let range = document.createRange();

	10 let text = document.querySelector('p').firstChild;

	11 range.setStart(text, 1);

	12 range.setEnd(text, 2);

	13

	14 selection.addRange(range);

	15 assert_equals(selection.anchorNode, text);
	yosin_UTC9 2017/02/10 10:26:27 Could you use assesrt_selection()? It is easier to Could you use assesrt_selection()? It is easier to verify where selection is rather than having four assert_equals() calls. tkent 2017/02/13 07:31:40 We can't test Range-Selection relationship behavio Show quoted text On 2017/02/10 at 10:26:27, yosin_UTC9 wrote: > Could you use assesrt_selection()? It is easier to verify where selection is rather than having four assert_equals() calls. We can't test Range-Selection relationship behavior with assert_selection(), which doesn't use Range at all.
	16 assert_equals(selection.anchorOffset, 1);

	17 assert_equals(selection.focusNode, text);

	18 assert_equals(selection.focusOffset, 2);

	19

	20 range.setStart(text, 0);

	21 assert_equals(selection.anchorOffset, 0);

	22 }, 'Mutation of Range after adding it to Selection should update Selection attri butes.');

	23 </script>

OLD	NEW