Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 268723002: Remove MockWebSpeechInputController (Closed)

Created:
6 years, 7 months ago by hans
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Remove MockWebSpeechInputController It was used to run the x-webkit-speech layout tests, which have been removed. This depends on Blink r173128. BUG=223198 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -353 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebSpeechInputController.h View 1 chunk +0 lines, -81 lines 0 comments Download
D content/shell/renderer/test_runner/MockWebSpeechInputController.cpp View 1 chunk +0 lines, -187 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.h View 6 chunks +0 lines, -11 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.cpp View 5 chunks +0 lines, -31 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +1 line, -5 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 5 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
hans
tommi: please take a look dmazzoni: please take an owner's look This depends on https://codereview.chromium.org/264973003/
6 years, 7 months ago (2014-05-01 21:18:45 UTC) #1
tommi (sloooow) - chröme
lgtm
6 years, 7 months ago (2014-05-01 21:21:21 UTC) #2
dmazzoni
lgtm
6 years, 7 months ago (2014-05-01 21:48:33 UTC) #3
hans
The layout tests were removed in Blink r173128, which was rolled in Chromium in r267766.
6 years, 7 months ago (2014-05-02 16:57:09 UTC) #4
hans
The CQ bit was checked by hans@chromium.org
6 years, 7 months ago (2014-05-02 16:57:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/268723002/1
6 years, 7 months ago (2014-05-02 16:57:49 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 17:34:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 17:34:34 UTC) #8
hans
The CQ bit was checked by hans@chromium.org
6 years, 7 months ago (2014-05-02 18:46:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/268723002/1
6 years, 7 months ago (2014-05-02 18:46:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 20:31:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 20:31:26 UTC) #12
hans
The CQ bit was checked by hans@chromium.org
6 years, 7 months ago (2014-05-02 22:12:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/268723002/1
6 years, 7 months ago (2014-05-02 22:12:52 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 22:18:27 UTC) #15
Message was sent while issue was closed.
Change committed as 267942

Powered by Google App Engine
This is Rietveld 408576698