Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: chrome/browser/android/webapk/webapk_installer.cc

Issue 2687163002: Add logs for WebAPK server failures (Closed)
Patch Set: Merge branch 'master' into better_logs Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapk/webapk_installer.cc
diff --git a/chrome/browser/android/webapk/webapk_installer.cc b/chrome/browser/android/webapk/webapk_installer.cc
index 2d17c84918a80ebbe6e541a35974d4458cc193b5..059d85f9889a83f75c5d33e645579daa3b0fe827 100644
--- a/chrome/browser/android/webapk/webapk_installer.cc
+++ b/chrome/browser/android/webapk/webapk_installer.cc
@@ -402,6 +402,8 @@ void WebApkInstaller::OnURLFetchComplete(const net::URLFetcher* source) {
if (!source->GetStatus().is_success() ||
source->GetResponseCode() != net::HTTP_OK) {
+ LOG(WARNING) << base::StringPrintf(
+ "WebAPK server returned response code %d.", source->GetResponseCode());
OnFailure();
return;
}
@@ -411,6 +413,7 @@ void WebApkInstaller::OnURLFetchComplete(const net::URLFetcher* source) {
std::unique_ptr<webapk::WebApkResponse> response(new webapk::WebApkResponse);
if (!response->ParseFromString(response_string)) {
+ LOG(WARNING) << "WebAPK server did not return proto.";
OnFailure();
return;
}
@@ -424,6 +427,7 @@ void WebApkInstaller::OnURLFetchComplete(const net::URLFetcher* source) {
}
if (!signed_download_url.is_valid() || response->package_name().empty()) {
+ LOG(WARNING) << "WebAPK server returned incomplete proto.";
OnFailure();
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698