Add logs for WebAPK server failures

chrome/browser/android/webapk/webapk_installer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include "base/android/build_info.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/path_utils.h"
@@ skipping 382 matching lines @@
       GetBackgroundTaskRunner().get(), FROM_HERE,
       base::Bind(&BuildWebApkProtoInBackground, shortcut_info_, shortcut_icon_,
                  icon_url_to_murmur2_hash, is_manifest_stale),
       base::Bind(&WebApkInstaller::SendUpdateWebApkRequest,
                  weak_ptr_factory_.GetWeakPtr()));
 }
 
 void WebApkInstaller::OnURLFetchComplete(const net::URLFetcher* source) {
   timer_.Stop();
 
-  if (!source->GetStatus().is_success() ||
-      source->GetResponseCode() != net::HTTP_OK) {
+  int response_code = source->GetResponseCode();
+  std::string response_string;
+  source->GetResponseAsString(&response_string);
+
+  if (!source->GetStatus().is_success() || response_code != net::HTTP_OK) {
+    LOG(WARNING) << base::StringPrintf(
+        "WebAPK server returned response code %d %s.", response_code,
+        response_string.c_str());

[pkotwicz, 2017/02/09 21:23:56]

The response string won't look too pretty right now because it is a proto even
for errors

[Xi Han, 2017/02/09 22:02:14]

I don't think we should put the entire response_string in the log, only
|response_code| should be enough.

[pkotwicz, 2017/02/09 22:54:22]

Done.

     OnFailure();
     return;
   }
 
-  std::string response_string;
-  source->GetResponseAsString(&response_string);
-
   std::unique_ptr<webapk::WebApkResponse> response(new webapk::WebApkResponse);
   if (!response->ParseFromString(response_string)) {
+    LOG(WARNING) << "WebAPK server did not return proto.";
     OnFailure();
     return;
   }
 
   GURL signed_download_url(response->signed_download_url());
   if (!signed_download_url.is_valid() || response->package_name().empty()) {
+    LOG(WARNING) << "WebAPK server returned incomplete proto.";
     OnFailure();
     return;
   }
 
   if (CanUseGooglePlayInstallService()) {
     int version = 1;
     base::StringToInt(response->version(), &version);
     // TODO(hanxi): crbug.com/688759. Remove the return value of
     // InstallOrUpdateWebApkFromGooglePlay(), since a callback will be called
     // asynchronously after the install or upidate has either failed or
@@ skipping 189 matching lines @@
 
 void WebApkInstaller::OnSuccess() {
   finish_callback_.Run(true, webapk_package_);
   delete this;
 }
 
 void WebApkInstaller::OnFailure() {
   finish_callback_.Run(false, webapk_package_);
   delete this;
 }