Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart

Issue 2687143005: Include metadata in AOT to expand inline frames in stack traces and provide line numbers. (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/tests/vm/dart/optimized_stacktrace_line_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
diff --git a/runtime/tests/vm/dart/optimized_stacktrace_test.dart b/runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
similarity index 69%
copy from runtime/tests/vm/dart/optimized_stacktrace_test.dart
copy to runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
index d002a2e28b0c32c11d9830998c9206ebb6e96297..0460aaef00dd6de21b6828f72fa2dfe0d13c11c5 100644
--- a/runtime/tests/vm/dart/optimized_stacktrace_test.dart
+++ b/runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
@@ -19,8 +19,9 @@ test1() {
Expect.fail("Unreachable");
} catch (e, stacktrace) {
String s = stacktrace.toString();
- Expect.isFalse(s.contains("-1:-1"));
- Expect.isTrue(s.contains("11:18"));
+ print(s);
+ Expect.isFalse(s.contains("-1:-1"), "A");
+ Expect.isTrue(s.contains("optimized_stacktrace_line_and_column_test.dart:11:18"), "B");
}
// Optimized.
@@ -30,8 +31,9 @@ test1() {
Expect.fail("Unreachable");
} catch (e, stacktrace) {
String s = stacktrace.toString();
- Expect.isFalse(s.contains("-1:-1"));
- Expect.isTrue(s.contains("11:18"));
+ print(s);
+ Expect.isFalse(s.contains("-1:-1"), "C");
+ Expect.isTrue(s.contains("optimized_stacktrace_line_and_column_test.dart:11:18"), "D");
}
}
@@ -56,9 +58,9 @@ test2() {
} catch (e, stacktrace) {
String s = stacktrace.toString();
print(s);
- Expect.isTrue(s.contains("maximus"));
- Expect.isTrue(s.contains("moritz"));
- Expect.isFalse(s.contains("-1:-1"));
+ Expect.isTrue(s.contains("maximus"), "E");
+ Expect.isTrue(s.contains("moritz"), "F");
+ Expect.isFalse(s.contains("-1:-1"), "G");
}
try {
@@ -66,9 +68,9 @@ test2() {
} catch (e, stacktrace) {
String s = stacktrace.toString();
print(s);
- Expect.isTrue(s.contains("maximus"));
- Expect.isTrue(s.contains("moritz"));
- Expect.isFalse(s.contains("-1:-1"));
+ Expect.isTrue(s.contains("maximus"), "H");
+ Expect.isTrue(s.contains("moritz"), "I");
+ Expect.isFalse(s.contains("-1:-1"), "J");
}
}
« no previous file with comments | « no previous file | runtime/tests/vm/dart/optimized_stacktrace_line_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698